From: "Bjørn Mork" <bjorn@mork.no>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: netdev@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "net: cx82310_eth: use common match macro"
Date: Thu, 19 Mar 2015 09:21:30 +0100 [thread overview]
Message-ID: <87y4mtcs8l.fsf@nemi.mork.no> (raw)
In-Reply-To: <1426716061-20953-1-git-send-email-linux@rainbow-software.org> (Ondrej Zary's message of "Wed, 18 Mar 2015 23:01:01 +0100")
Ondrej Zary <linux@rainbow-software.org> writes:
> This reverts commit 11ad714b98f6d9ca0067568442afe3e70eb94845 because
> it breaks cx82310_eth.
>
> The custom USB_DEVICE_CLASS macro matches
> bDeviceClass, bDeviceSubClass and bDeviceProtocol
> but the common USB_DEVICE_AND_INTERFACE_INFO matches
> bInterfaceClass, bInterfaceSubClass and bInterfaceProtocol instead, which are
> not specified.
Ouch. What ever made me do that? Thanks a lot for fixing it!
This bug was introduced as long ago as v3.7, so the fix should go into
every currently maintained stable branch since that.
Bjørn
next prev parent reply other threads:[~2015-03-19 8:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 22:01 Ondrej Zary
2015-03-19 2:38 ` David Miller
2015-03-19 8:21 ` Bjørn Mork [this message]
2015-03-19 16:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4mtcs8l.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome