From: Alex Romosan <romosan@sycorax.lbl.gov>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] missing ifdef in mod_devicetable.h for 2.6.14-rc3
Date: Sat, 01 Oct 2005 08:48:14 -0700 [thread overview]
Message-ID: <87y85d9r29.fsf@sycorax.lbl.gov> (raw)
In-Reply-To: <1128179737.2916.6.camel@laptopd505.fenrus.org> (message from Arjan van de Ven on Sat, 01 Oct 2005 17:15:36 +0200)
Arjan van de Ven <arjan@infradead.org> writes:
> On Sat, 2005-10-01 at 08:03 -0700, Alex Romosan wrote:
>> this was introduced in rc1 and is still present in rc3. without the
>> patch below i can't compile alsa cvs.
>
>
> while our patch isn't wrong... makes me wonder if alsa cvs has a bug in
> their makefiles ...
>
well, it could be that their check is wrong:
AC_TRY_COMPILE([
#define __KERNEL__
#include <linux/config.h>
#include <linux/pci.h>
],[
int (*func)();
func = pci_set_consistent_dma_mask;
],
AC_MSG_RESULT("yes");pci_consistent_defined="1",
AC_MSG_RESULT("no");pci_consistent_defined="0",
AC_MSG_RESULT("unknown");pci_consistent_defined="0"
)
notice the '#define __KERNEL__'. this gives:
/usr/src/linux/include/linux/mod_devicetable.h:186:15: error: #if with no expression
replacing the above with '#define __KERNEL__ 1' (there and in a
million other places where this happens) solves the problem.
--alex--
--
| I believe the moment is at hand when, by a paranoiac and active |
| advance of the mind, it will be possible (simultaneously with |
| automatism and other passive states) to systematize confusion |
| and thus to help to discredit completely the world of reality. |
prev parent reply other threads:[~2005-10-01 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-01 15:03 Alex Romosan
2005-10-01 15:15 ` Arjan van de Ven
2005-10-01 15:48 ` Alex Romosan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y85d9r29.fsf@sycorax.lbl.gov \
--to=romosan@sycorax.lbl.gov \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®