* [PATCH] missing ifdef in mod_devicetable.h for 2.6.14-rc3
@ 2005-10-01 15:03 Alex Romosan
2005-10-01 15:15 ` Arjan van de Ven
0 siblings, 1 reply; 3+ messages in thread
From: Alex Romosan @ 2005-10-01 15:03 UTC (permalink / raw)
To: linux-kernel
this was introduced in rc1 and is still present in rc3. without the
patch below i can't compile alsa cvs.
--- a/include/linux/mod_devicetable.h 2005-09-13 13:49:17.000000000 -0700
+++ b/include/linux/mod_devicetable.h 2005-09-13 13:49:43.000000000 -0700
@@ -183,7 +183,7 @@
char name[32];
char type[32];
char compatible[128];
-#if __KERNEL__
+#ifdef __KERNEL__
void *data;
#else
kernel_ulong_t data;
--alex--
--
| I believe the moment is at hand when, by a paranoiac and active |
| advance of the mind, it will be possible (simultaneously with |
| automatism and other passive states) to systematize confusion |
| and thus to help to discredit completely the world of reality. |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] missing ifdef in mod_devicetable.h for 2.6.14-rc3
2005-10-01 15:03 [PATCH] missing ifdef in mod_devicetable.h for 2.6.14-rc3 Alex Romosan
@ 2005-10-01 15:15 ` Arjan van de Ven
2005-10-01 15:48 ` Alex Romosan
0 siblings, 1 reply; 3+ messages in thread
From: Arjan van de Ven @ 2005-10-01 15:15 UTC (permalink / raw)
To: Alex Romosan; +Cc: linux-kernel
On Sat, 2005-10-01 at 08:03 -0700, Alex Romosan wrote:
> this was introduced in rc1 and is still present in rc3. without the
> patch below i can't compile alsa cvs.
while our patch isn't wrong... makes me wonder if alsa cvs has a bug in
their makefiles ...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] missing ifdef in mod_devicetable.h for 2.6.14-rc3
2005-10-01 15:15 ` Arjan van de Ven
@ 2005-10-01 15:48 ` Alex Romosan
0 siblings, 0 replies; 3+ messages in thread
From: Alex Romosan @ 2005-10-01 15:48 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: linux-kernel
Arjan van de Ven <arjan@infradead.org> writes:
> On Sat, 2005-10-01 at 08:03 -0700, Alex Romosan wrote:
>> this was introduced in rc1 and is still present in rc3. without the
>> patch below i can't compile alsa cvs.
>
>
> while our patch isn't wrong... makes me wonder if alsa cvs has a bug in
> their makefiles ...
>
well, it could be that their check is wrong:
AC_TRY_COMPILE([
#define __KERNEL__
#include <linux/config.h>
#include <linux/pci.h>
],[
int (*func)();
func = pci_set_consistent_dma_mask;
],
AC_MSG_RESULT("yes");pci_consistent_defined="1",
AC_MSG_RESULT("no");pci_consistent_defined="0",
AC_MSG_RESULT("unknown");pci_consistent_defined="0"
)
notice the '#define __KERNEL__'. this gives:
/usr/src/linux/include/linux/mod_devicetable.h:186:15: error: #if with no expression
replacing the above with '#define __KERNEL__ 1' (there and in a
million other places where this happens) solves the problem.
--alex--
--
| I believe the moment is at hand when, by a paranoiac and active |
| advance of the mind, it will be possible (simultaneously with |
| automatism and other passive states) to systematize confusion |
| and thus to help to discredit completely the world of reality. |
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-10-01 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-10-01 15:03 [PATCH] missing ifdef in mod_devicetable.h for 2.6.14-rc3 Alex Romosan
2005-10-01 15:15 ` Arjan van de Ven
2005-10-01 15:48 ` Alex Romosan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®