From: Takashi Iwai <tiwai@suse.de>
To: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
Cc: tiwai@suse.de, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, perex@perex.cz, tiwai@suse.com
Subject: Re: [PATCH v2] ALSA: control: Fix parsing of numeric fields
Date: Sun, 08 Nov 2026 13:06:28 +0100 [thread overview]
Message-ID: <87zevjwmrf.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261108111848.2493-1-sreekuttan2156239@gmail.com>
On Sun, 08 Nov 2026 12:18:48 +0100,
Sreeraj S Kurup wrote:
>
> Hi Takashi,
>
> I compared the approaches.
>
> Using simple_strtoul() would provide an end pointer, but it is deprecated.
>
> Another option is to retain kstrtoull() from the original implementation
> and apply the delimiter-first approach. This would minimize changes to the
> existing conversion logic.
>
> However, since the destination is an unsigned int, kstrtouint() better matches
> the destination type and also detects values outside the unsigned int range.
>
> I currently prefer the v2 approach, but wanted to point out this difference in
> overflow handling.
OK, thanks. Feel free to resubmit whatever you find better :)
Takashi
next prev parent reply other threads:[~2026-11-08 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 15:45 [PATCH] " Sreeraj S Kurup
2026-11-06 16:23 ` [PATCH v2] " Sreeraj S Kurup
2026-11-08 9:54 ` Sreeraj S Kurup
2026-11-08 10:44 ` Takashi Iwai
2026-11-08 11:18 ` Sreeraj S Kurup
2026-11-08 12:06 ` Takashi Iwai [this message]
2026-11-08 12:47 ` Sreeraj S Kurup
2026-11-08 12:48 ` [PATCH v3] " Sreeraj S Kurup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zevjwmrf.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sreekuttan2156239@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®