mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sreeraj S Kurup <sreekuttan2156239@gmail.com>
To: tiwai@suse.de
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	perex@perex.cz, sreekuttan2156239@gmail.com, tiwai@suse.com
Subject: Re: [PATCH v2] ALSA: control: Fix parsing of numeric fields
Date: Sun,  8 Nov 2026 11:18:48 +0000	[thread overview]
Message-ID: <20261108111848.2493-1-sreekuttan2156239@gmail.com> (raw)
In-Reply-To: <87a4njy53s.wl-tiwai@suse.de>

Hi Takashi,

I compared the approaches.

Using simple_strtoul() would provide an end pointer, but it is deprecated.

Another option is to retain kstrtoull() from the original implementation 
and apply the delimiter-first approach. This would minimize changes to the 
existing conversion logic.

However, since the destination is an unsigned int, kstrtouint() better matches 
the destination type and also detects values outside the unsigned int range.

I currently prefer the v2 approach, but wanted to point out this difference in 
overflow handling.

Thanks,
Sreeraj

  reply	other threads:[~2026-11-08 11:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 15:45 [PATCH] " Sreeraj S Kurup
2026-11-06 16:23 ` [PATCH v2] " Sreeraj S Kurup
2026-11-08  9:54   ` Sreeraj S Kurup
2026-11-08 10:44     ` Takashi Iwai
2026-11-08 11:18       ` Sreeraj S Kurup [this message]
2026-11-08 12:06         ` Takashi Iwai
2026-11-08 12:47           ` Sreeraj S Kurup
2026-11-08 12:48           ` [PATCH v3] " Sreeraj S Kurup
2026-11-08 16:48             ` Manuel Ebner
2026-11-09 14:33             ` Takashi Iwai
2026-11-09 15:58               ` Sreeraj S Kurup
2026-11-09 15:59             ` [PATCH v4] " Sreeraj S Kurup
2026-11-09 16:35             ` [PATCH v5] " Sreeraj S Kurup
2026-11-10 10:27               ` Takashi Iwai
2026-11-11 10:56                 ` Sreeraj S Kurup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261108111848.2493-1-sreekuttan2156239@gmail.com \
    --to=sreekuttan2156239@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®