* [PATCH v1] ALSA: hda/tas2781: Set tas2781_hda::tasdevice_priv::chip_id as TAS5825 in case of tas5825
@ 2025-10-13 4:35 Shenghao Ding
2025-10-13 7:40 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Shenghao Ding @ 2025-10-13 4:35 UTC (permalink / raw)
To: tiwai
Cc: broonie, andriy.shevchenko, alsa-devel, linux-kernel, baojun.xu,
Baojun.Xu, 13564923607, 13916275206, Shenghao Ding
The software reset for TAS5825 is different form other chips, as it will
set as 0x11 instead of 0x1 during reset in the tasdevice_reset(). So set
tas2781_hda::tasdevice_priv::chip_id as TAS5825, tasdevice_reset() can
work correctly.
Fixes: 7ceb69ca82b1 ("ASoC: tas2781: Add tas2118, tas2x20, tas5825 support")
Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
---
sound/hda/codecs/side-codecs/tas2781_hda_i2c.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c
index a126f04c3ed7..0357401a6023 100644
--- a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c
+++ b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c
@@ -669,6 +669,7 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt)
*/
device_name = "TXNW5825";
hda_priv->hda_chip_id = HDA_TAS5825;
+ tas_hda->priv->chip_id = TAS5825;
} else {
return -ENODEV;
}
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] ALSA: hda/tas2781: Set tas2781_hda::tasdevice_priv::chip_id as TAS5825 in case of tas5825
2025-10-13 4:35 [PATCH v1] ALSA: hda/tas2781: Set tas2781_hda::tasdevice_priv::chip_id as TAS5825 in case of tas5825 Shenghao Ding
@ 2025-10-13 7:40 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2025-10-13 7:40 UTC (permalink / raw)
To: Shenghao Ding
Cc: broonie, andriy.shevchenko, alsa-devel, linux-kernel, baojun.xu,
Baojun.Xu, 13564923607, 13916275206
On Mon, 13 Oct 2025 06:35:55 +0200,
Shenghao Ding wrote:
>
> The software reset for TAS5825 is different form other chips, as it will
> set as 0x11 instead of 0x1 during reset in the tasdevice_reset(). So set
> tas2781_hda::tasdevice_priv::chip_id as TAS5825, tasdevice_reset() can
> work correctly.
>
> Fixes: 7ceb69ca82b1 ("ASoC: tas2781: Add tas2118, tas2x20, tas5825 support")
> Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-13 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-13 4:35 [PATCH v1] ALSA: hda/tas2781: Set tas2781_hda::tasdevice_priv::chip_id as TAS5825 in case of tas5825 Shenghao Ding
2025-10-13 7:40 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®