From: Jakub Sitnicki <jakub@cloudflare.com>
To: Tao Chen <chen.dylane@linux.dev>
Cc: daniel@iogearbox.net, razor@blackwall.org,
andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
ast@kernel.org, andrii@kernel.org, martin.lau@linux.dev,
eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, jolsa@kernel.org, mattbobrowski@google.com,
rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, horms@kernel.org,
willemb@google.com, pablo@netfilter.org, kadlec@netfilter.org,
hawk@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org
Subject: Re: [PATCH bpf-next v3 0/7] Add attach_type in bpf_link
Date: Wed, 09 Jul 2025 10:22:09 +0200 [thread overview]
Message-ID: <87zfddepu6.fsf@cloudflare.com> (raw)
In-Reply-To: <20250709030802.850175-1-chen.dylane@linux.dev> (Tao Chen's message of "Wed, 9 Jul 2025 11:07:55 +0800")
On Wed, Jul 09, 2025 at 11:07 AM +08, Tao Chen wrote:
> Andrii suggested moving the attach_type into bpf_link, the previous discussion
> is as follows:
> https://lore.kernel.org/bpf/CAEf4BzY7TZRjxpCJM-+LYgEqe23YFj5Uv3isb7gat2-HU4OSng@mail.gmail.com
>
> patch1 add attach_type in bpf_link, and pass it to bpf_link_init, which
> will init the attach_type field.
>
> patch2-7 remove the attach_type in struct bpf_xx_link, update the info
> with bpf_link attach_type.
>
> There are some functions finally call bpf_link_init but do not have bpf_attr
> from user or do not need to init attach_type from user like bpf_raw_tracepoint_open,
> now use prog->expected_attach_type to init attach_type.
>
> bpf_struct_ops_map_update_elem
> bpf_raw_tracepoint_open
> bpf_struct_ops_test_run
>
> Feedback of any kind is welcome, thanks.
>
> Tao Chen (7):
> bpf: Add attach_type in bpf_link
> bpf: Remove attach_type in bpf_cgroup_link
> bpf: Remove attach_type in sockmap_link
> bpf: Remove location field in tcx_link
> bpf: Remove attach_type in bpf_netns_link
> bpf: Remove attach_type in bpf_tracing_link
> netkit: Remove location field in netkit_link
For the series:
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
prev parent reply other threads:[~2025-07-09 8:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 3:07 Tao Chen
2025-07-09 3:07 ` [PATCH bpf-next v3 1/7] bpf: " Tao Chen
2025-07-09 13:15 ` Daniel Borkmann
2025-07-09 3:07 ` [PATCH bpf-next v3 2/7] bpf: Remove attach_type in bpf_cgroup_link Tao Chen
2025-07-09 13:07 ` Daniel Borkmann
2025-07-09 3:07 ` [PATCH bpf-next v3 3/7] bpf: Remove attach_type in sockmap_link Tao Chen
2025-07-09 13:07 ` Daniel Borkmann
2025-07-09 3:07 ` [PATCH bpf-next v3 4/7] bpf: Remove location field in tcx_link Tao Chen
2025-07-09 10:39 ` Daniel Borkmann
2025-07-09 3:08 ` [PATCH bpf-next v3 5/7] bpf: Remove attach_type in bpf_netns_link Tao Chen
2025-07-09 8:21 ` Jakub Sitnicki
2025-07-09 8:58 ` Tao Chen
2025-07-09 3:08 ` [PATCH bpf-next v3 6/7] bpf: Remove attach_type in bpf_tracing_link Tao Chen
2025-07-09 3:08 ` [PATCH bpf-next v3 7/7] netkit: Remove location field in netkit_link Tao Chen
2025-07-09 7:37 ` Nikolay Aleksandrov
2025-07-09 10:39 ` Daniel Borkmann
2025-07-09 8:22 ` Jakub Sitnicki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfddepu6.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chen.dylane@linux.dev \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mathieu.desnoyers@efficios.com \
--cc=mattbobrowski@google.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=razor@blackwall.org \
--cc=rostedt@goodmis.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=willemb@google.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®