From: Kalle Valo <kvalo@kernel.org>
To: Chen Ni <nichen@iscas.ac.cn>
Cc: gregory.greenman@intel.com, johannes.berg@intel.com,
mukesh.sisodiya@intel.com, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: iwlwifi: Add check for kmemdup
Date: Mon, 23 Oct 2023 12:08:48 +0300 [thread overview]
Message-ID: <87zg09zowv.fsf@kernel.org> (raw)
In-Reply-To: <20231023064501.274599-1-nichen@iscas.ac.cn> (Chen Ni's message of "Mon, 23 Oct 2023 06:45:01 +0000")
Chen Ni <nichen@iscas.ac.cn> writes:
> Since the kmemdup may return NULL pointer,
> it should be better to add check for the return value
> in order to avoid NULL pointer dereference.
>
> Fixes: 5e31b3df86ec ("wifi: iwlwifi: dbg: print pc register data once
> fw dump occurred")
The fixes tag should be in one line.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-10-23 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 6:45 Chen Ni
2023-10-23 9:08 ` Kalle Valo [this message]
2023-10-23 9:10 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg09zowv.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=gregory.greenman@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mukesh.sisodiya@intel.com \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®