mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Max Kellermann <max.kellermann@ionos.com>
Cc: dhowells@redhat.com, netfs@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/netfs/read_collect: remove duplicate line
Date: Mon, 28 Apr 2025 16:41:46 +0100	[thread overview]
Message-ID: <88037.1745854906@warthog.procyon.org.uk> (raw)
In-Reply-To: <20250428114842.3180169-1-max.kellermann@ionos.com>

Max Kellermann <max.kellermann@ionos.com> wrote:

> The `ret` variable has already been assigned before the `switch`
> block.
> 
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
> Fixes: e2d46f2ec332 ("netfs: Change the read result collector to only use one work item")

Please hold off on this one.  I want to submit the two patches at the bottom
of here instead:

	https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes

	netfs: Fix the request's work item to not require a ref
	netfs: Fix wait/wake to be consistent about the waitqueue used

and this code gets moved and commonalised with the wait-for-write functions.

The reason I haven't posted them yet is that there may be an issue with cifs -
and only in Steve's testfarm - though I'm not sure whether it's actually
directly related to the changes here or whether it was masked just by it.

Thanks,
David


      parent reply	other threads:[~2025-04-28 15:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-28 11:48 Max Kellermann
2025-04-28 13:36 ` Paulo Alcantara
     [not found] ` <notmuch-sha1-fe1ebcd5fc23eab1dc1cf15f4369d4b0ea567ded>
2025-04-28 13:38   ` Paulo Alcantara
2025-04-28 15:41 ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88037.1745854906@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max.kellermann@ionos.com \
    --cc=netfs@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®