From: Paulo Alcantara <pc@manguebit.com>
To: Max Kellermann <max.kellermann@ionos.com>,
dhowells@redhat.com, netfs@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: Max Kellermann <max.kellermann@ionos.com>
Subject: Re: [PATCH] fs/netfs/read_collect: remove duplicate line
Date: Mon, 28 Apr 2025 10:38:39 -0300 [thread overview]
Message-ID: <a83bf0565fccbe448ab1a350def86f91@manguebit.com> (raw)
In-Reply-To: <notmuch-sha1-fe1ebcd5fc23eab1dc1cf15f4369d4b0ea567ded>
Paulo Alcantara <pc@manguebit.com> writes:
> Max Kellermann <max.kellermann@ionos.com> writes:
>
>> @@ -653,7 +653,6 @@ ssize_t netfs_wait_for_read(struct netfs_io_request *rreq)
>> switch (rreq->origin) {
>> case NETFS_DIO_READ:
>> case NETFS_READ_SINGLE:
>> - ret = rreq->transferred;
>> break;
>> default:
>> if (rreq->submitted < rreq->len) {
>
> This is wrong. @ret is expected to have the amount of bytes
> successfully read if no error.
Err, sorry. I just saw the assignment right after if (ret == 0) check.
Looks good,
Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
next prev parent reply other threads:[~2025-04-28 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 11:48 Max Kellermann
2025-04-28 13:36 ` Paulo Alcantara
[not found] ` <notmuch-sha1-fe1ebcd5fc23eab1dc1cf15f4369d4b0ea567ded>
2025-04-28 13:38 ` Paulo Alcantara [this message]
2025-04-28 15:41 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a83bf0565fccbe448ab1a350def86f91@manguebit.com \
--to=pc@manguebit.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=max.kellermann@ionos.com \
--cc=netfs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®