From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Maxim Storetvedt <mstoretv@cern.ch>,
andersson@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: marcus@nazgul.ch, marijn.suijten@somainline.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, abel.vesa@linaro.org,
abel.vesa@oss.qualcomm.com, johan@kernel.org,
konradybcio@kernel.org, kirill@korins.ky
Subject: Re: [PATCH v6 3/3] arm64: dts: qcom: Add Samsung Galaxy Book4 Edge DTS/DTSI
Date: Mon, 23 Mar 2026 13:17:51 +0100 [thread overview]
Message-ID: <881975ea-cc16-4b26-9672-731c146a1ba8@oss.qualcomm.com> (raw)
In-Reply-To: <20260322160317.424797-4-mstoretv@cern.ch>
On 3/22/26 5:03 PM, Maxim Storetvedt wrote:
> Adds devicetrees for the 14-inch and 16-inch SKUs of the Samsung Galaxy Book4 Edge.
>
> These use a common dtsi derived from nodes that were able to work on Linux
> from the initial Galaxy Book4 Edge DTS by Marcus:
>
> Link: https://lore.kernel.org/all/p3mhtj2rp6y2ezuwpd2gu7dwx5cbckfu4s4pazcudi4j2wogtr@4yecb2bkeyms/
>
> combined with the ongoing patch for the Honor Magicbook Art 14, and its downstream by
> Valentin Manea, which shares device similarities:
[...]
> + model = "Samsung Galaxy Book4 Edge";
> + compatible = "samsung,galaxy-book4-edge", "qcom,x1e80100";
> + chassis-type = "laptop";
> +
> + aliases {
> + serial0 = &uart21;
> + serial1 = &uart14;
> + };
> +
> + wcd938x: audio-codec {
> + compatible = "qcom,wcd9385-codec";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&wcd_default>;
property-n
property-names
in this order, file-wide, please
[...]
> + pmic-glink {
> + compatible = "qcom,x1e80100-pmic-glink",
> + "qcom,pmic-glink";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>,
> + <&tlmm 123 GPIO_ACTIVE_HIGH>,
> + <&tlmm 125 GPIO_ACTIVE_HIGH>;
You provide 3 orientation-gpios but there's only two ports
[...]
> + sound {
> + compatible = "qcom,x1e80100-sndcard";
> + model = "X1E80100-CRD";
This should reflect the actual machine
> + audio-routing = "WooferLeft IN", "WSA WSA_SPK1 OUT",
> + "TweeterLeft IN", "WSA WSA_SPK2 OUT",
> + "WooferRight IN", "WSA2 WSA_SPK2 OUT",
> + "TweeterRight IN", "WSA2 WSA_SPK2 OUT",
> + "IN1_HPHL", "HPHL_OUT",
> + "IN2_HPHR", "HPHR_OUT",
> + "AMIC2", "MIC BIAS2",
> + "VA DMIC0", "MIC BIAS3",
> + "VA DMIC1", "MIC BIAS3",
> + "VA DMIC2", "MIC BIAS1",
> + "VA DMIC3", "MIC BIAS1",
> + "VA DMIC0", "VA MIC BIAS3",
> + "VA DMIC1", "VA MIC BIAS3",
> + "VA DMIC2", "VA MIC BIAS1",
> + "VA DMIC3", "VA MIC BIAS1",
See:
b49e37de8e70 ("arm64: dts: qcom: x1e80100-crd: Drop duplicate DMIC supplies")
> + "TX SWR_INPUT1", "ADC2_OUTPUT";
> +
> + wcd-playback-dai-link {
> + link-name = "WCD Playback";
> +
> + cpu {
> + sound-dai = <&q6apmbedai RX_CODEC_DMA_RX_0>;
> + };
> +
> + codec {
'co'dec < 'cp'u, please reorder
[...]
> +&i2c8 {
> + clock-frequency = <400000>;
> +
> + status = "okay";
> +
> + touchscreen@5d {
> + compatible = "hid-over-i2c";
> + reg = <0x5d>;
> +
> + hid-descr-addr = <0x1>;
> + interrupts-extended = <&tlmm 34 IRQ_TYPE_LEVEL_LOW>;
> +
> + vdd-supply = <&vreg_misc_3p3>;
> + /* Lower power supply is not enoug to work. */
> + // vddl-supply = <&vreg_l15b_1p8>;
How should we interpret that?
[...]
> +/* usb1 covers left side typec ports */
> +
> +/* back(towards the display) typec port */
You already have these comments near the type-c connector definitions
at the top of the file
[...]
> +/* DP-HDMI bridge connected here? */
> +&usb_1_ss2_qmpphy {
> + vdda-phy-supply = <&vreg_l2j_1p2>;
> + vdda-pll-supply = <&vreg_l2d_0p9>;
> +
> + qcom,combo-initial-mode = "dp";
This was used in some previous version of the QMPPHY-DP-only patchset,
see e.g. x1p42100-lenovo-thinkbook-16.dts and align with that to get
it working again
[...]
> +&panel {
> + compatible = "samsung,atna40cu07", "samsung,atna33xc20";
I think it'd make sense to move the compatible from 'common' to the
16in DTS then too
> + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
this matches the common definition
> + power-supply = <&vreg_edp_3p3>;
ditto
> + no-hpd;
really??
Konrad
next prev parent reply other threads:[~2026-03-23 12:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-17 20:32 [PATCH v5 0/6] Add initial DTS for Samsung Galaxy Book4 Edge Marcus Glocker
2024-08-17 20:33 ` [PATCH v5 1/6] dt-bindings: crypto: Add X1E80100 Crypto Engine Marcus Glocker
2024-08-17 20:34 ` [PATCH v5 2/6] dt-bindings: phy: Add X1E80100 UFS Marcus Glocker
2024-08-17 20:36 ` [PATCH v5 3/6] dt-bindings: ufs: " Marcus Glocker
2024-08-18 6:41 ` Krzysztof Kozlowski
2024-08-17 20:38 ` [PATCH v5 4/6] arm64: dts: qcom: Add UFS node Marcus Glocker
2024-08-30 0:05 ` Konrad Dybcio
2024-08-30 17:25 ` Marcus Glocker
2024-11-09 23:31 ` Daniel Gomez
2025-01-02 21:38 ` Wesley Cheng
2025-01-02 23:17 ` Marcus Glocker
2026-03-07 16:01 ` Maxim Storetvedt
2026-03-08 20:35 ` Marcus Glocker
2026-03-19 11:31 ` Konrad Dybcio
2024-08-30 7:02 ` Johan Hovold
2024-08-17 20:40 ` [PATCH v5 5/6] dt-bindings: arm: Add Samsung Galaxy Book4 Edge Marcus Glocker
2024-08-17 20:41 ` [PATCH v5 6/6] arm64: dts: qcom: Add Samsung Galaxy Book4 Edge DTS Marcus Glocker
2026-03-22 16:03 ` [PATCH v6 0/3] Add initial DTS for Samsung Galaxy Book4 Edge Maxim Storetvedt
2026-03-22 16:03 ` [PATCH v6 1/3] firmware: qcom: scm: Allow QSEECOM on " Maxim Storetvedt
2026-03-22 18:40 ` Dmitry Baryshkov
2026-03-22 16:03 ` [PATCH v6 2/3] dt-bindings: arm: Add " Maxim Storetvedt
2026-03-26 11:44 ` Krzysztof Kozlowski
2026-03-26 18:40 ` Maxim Storetvedt
2026-03-22 16:03 ` [PATCH v6 3/3] arm64: dts: qcom: Add Samsung Galaxy Book4 Edge DTS/DTSI Maxim Storetvedt
2026-03-23 12:17 ` Konrad Dybcio [this message]
2026-03-25 18:30 ` Maxim Storetvedt
2026-03-26 11:33 ` Konrad Dybcio
2026-03-26 18:30 ` Maxim Storetvedt
2026-03-30 10:41 ` Konrad Dybcio
2026-03-30 10:54 ` Dmitry Baryshkov
2026-03-31 16:34 ` Maxim Storetvedt
2026-04-07 11:55 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=881975ea-cc16-4b26-9672-731c146a1ba8@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abel.vesa@linaro.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=kirill@korins.ky \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus@nazgul.ch \
--cc=marijn.suijten@somainline.org \
--cc=mstoretv@cern.ch \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®