mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philippe CORNU <philippe.cornu@st.com>
To: Yannick FERTRE <yannick.fertre@st.com>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Vincent ABRIOU <vincent.abriou@st.com>,
	"David Airlie" <airlied@linux.ie>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre TORGUE <alexandre.torgue@st.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Mickael REULIER <mickael.reulier@st.com>,
	Gabriel FERNANDEZ <gabriel.fernandez@st.com>,
	Ludovic BARRE <ludovic.barre@st.com>
Subject: Re: [PATCH] dt-bindings: display: stm32: add pixel clock mandatory property
Date: Thu, 25 Jan 2018 16:08:35 +0000	[thread overview]
Message-ID: <881ad794-6c4a-b753-2325-ac8522f8a70c@st.com> (raw)
In-Reply-To: <20180122153805.23720-1-philippe.cornu@st.com>

Hi,

in short: this patch is "CANCELLED" : )

There is no need to add the pixel clock as a mandatory property because 
now the clock value is ajusted in adjusted_mode.

Please have a look to patches:
- drm/stm: ltdc: use crtc_mode_fixup to update adjusted_mode clock
- drm/bridge/synopsys: dsi: use adjusted_mode in mode_set

Hope it is better, comments are welcome

Many thanks,
Philippe :-)

On 01/22/2018 04:38 PM, Philippe Cornu wrote:
> Add the DPI/RGB input pixel clock in mandatory properties
> because it really offers a better preciseness for timing
> computations.
> 
> Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
> ---
> Please apply "dt-bindings: display: stm32: correct clock-names
> in dsi panel example" before this patch.
> 
> Changes in v3: remove the note regarding swapped clock names
>    (now in a separate patch).
> Changes in v2: put new clock in last position (Rob Herring)
> 
>   Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> index 3eb1b48b47dd..942b7237ae87 100644
> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> @@ -29,6 +29,7 @@ Mandatory properties specific to STM32 DSI:
>   - compatible: "st,stm32-dsi".
>   - clock-names:
>     - phy pll reference clock string name, must be "ref".
> +  - DPI/RGB input pixel clock string name, must be "px_clk".
>   - resets: see [5].
>   - reset-names: see [5].
>   
> @@ -97,8 +98,9 @@ Example 2: DSI panel
>   			#size-cells = <0>;
>   			compatible = "st,stm32-dsi";
>   			reg = <0x40016c00 0x800>;
> -			clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
> -			clock-names = "pclk", "ref";
> +			clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>,
> +				 <&rcc 1 CLK_LCD>;
> +			clock-names = "pclk", "ref", "px_clk";
>   			resets = <&rcc STM32F4_APB2_RESET(DSI)>;
>   			reset-names = "apb";
>   
> 

  reply	other threads:[~2018-01-25 16:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22 15:38 Philippe Cornu
2018-01-25 16:08 ` Philippe CORNU [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-01-21 21:13 Philippe Cornu
2017-10-26 16:12 Philippe Cornu
2017-10-27 14:38 ` Rob Herring
2017-10-27 14:52   ` Philippe CORNU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=881ad794-6c4a-b753-2325-ac8522f8a70c@st.com \
    --to=philippe.cornu@st.com \
    --cc=airlied@linux.ie \
    --cc=alexandre.torgue@st.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gabriel.fernandez@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.barre@st.com \
    --cc=mark.rutland@arm.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mickael.reulier@st.com \
    --cc=robh+dt@kernel.org \
    --cc=vincent.abriou@st.com \
    --cc=yannick.fertre@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®