From: Michal Simek <michal.simek@xilinx.com>
To: Piyush Mehta <piyush.mehta@xilinx.com>,
axboe@kernel.dk, p.zabel@pengutronix.de, robh+dt@kernel.org
Cc: linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, git@xilinx.com, sgoud@xilinx.com,
michal.simek@xilinx.com
Subject: Re: [PATCH 2/2] dt-bindings: ata: achi: ceva: Update documentation for CEVA Controller
Date: Fri, 4 Sep 2020 09:23:11 +0200 [thread overview]
Message-ID: <882b16f2-fb6d-4029-3b79-a97be5edc1f3@xilinx.com> (raw)
In-Reply-To: <1599030348-3334-3-git-send-email-piyush.mehta@xilinx.com>
On 02. 09. 20 9:05, Piyush Mehta wrote:
> This patch updates the documentation for the CEVA controller for adding
> the required properties for 'phys' and 'resets'.
>
> Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com>
> ---
> Documentation/devicetree/bindings/ata/ahci-ceva.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-ceva.txt b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> index 7561cc4..f01d317 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> @@ -35,6 +35,10 @@ Required properties:
> ceva,pN-retry-params = /bits/ 16 <RIT RCT>;
> RIT: Retry Interval Timer.
> RCT: Rate Change Timer.
> + - phys: phandle for the PHY device
> + - phy-names: Should be "sata-phy"
> + - resets: phandle to the reset controller for the SATA IP
> + - reset-names: Should be "sata_rst".
I expect that these can't be required properties because you break all
existing boards.
Thanks
Michal
next prev parent reply other threads:[~2020-09-04 7:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 7:05 [PATCH 0/2] ata: ahci: ceva: Update the driver to support xilinx GT phy Piyush Mehta
2020-09-02 7:05 ` [PATCH 1/2] " Piyush Mehta
2020-09-02 7:05 ` [PATCH 2/2] dt-bindings: ata: achi: ceva: Update documentation for CEVA Controller Piyush Mehta
2020-09-04 7:23 ` Michal Simek [this message]
2020-09-14 20:08 ` Rob Herring
2020-09-15 6:40 ` Piyush Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=882b16f2-fb6d-4029-3b79-a97be5edc1f3@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=axboe@kernel.dk \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=piyush.mehta@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=sgoud@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®