From: Piyush Mehta <piyushm@xilinx.com>
To: Rob Herring <robh@kernel.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
git <git@xilinx.com>, Srinivas Goud <sgoud@xilinx.com>,
Michal Simek <michals@xilinx.com>
Subject: RE: [PATCH 2/2] dt-bindings: ata: achi: ceva: Update documentation for CEVA Controller
Date: Tue, 15 Sep 2020 06:40:33 +0000 [thread overview]
Message-ID: <BYAPR02MB397553291F489C01FC8C3A88D4200@BYAPR02MB3975.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20200914200840.GA152914@bogus>
Hello Rob Herring,
Thanks for review.
Regards,
Piyush Mehta
-----Original Message-----
From: Rob Herring <robh@kernel.org>
Sent: Tuesday, September 15, 2020 1:39 AM
To: Piyush Mehta <piyushm@xilinx.com>
Cc: axboe@kernel.dk; p.zabel@pengutronix.de; linux-ide@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; git <git@xilinx.com>; Srinivas Goud <sgoud@xilinx.com>; Michal Simek <michals@xilinx.com>
Subject: Re: [PATCH 2/2] dt-bindings: ata: achi: ceva: Update documentation for CEVA Controller
On Wed, Sep 02, 2020 at 12:35:48PM +0530, Piyush Mehta wrote:
> This patch updates the documentation for the CEVA controller for
> adding the required properties for 'phys' and 'resets'.
>
> Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com>
> ---
> Documentation/devicetree/bindings/ata/ahci-ceva.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> index 7561cc4..f01d317 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-ceva.txt
> @@ -35,6 +35,10 @@ Required properties:
> ceva,pN-retry-params = /bits/ 16 <RIT RCT>;
> RIT: Retry Interval Timer.
> RCT: Rate Change Timer.
> + - phys: phandle for the PHY device
> + - phy-names: Should be "sata-phy"
> + - resets: phandle to the reset controller for the SATA IP
> + - reset-names: Should be "sata_rst".
The names here are rather pointless. You don't really need them if only
1 entry.
>
> Optional properties:
> - ceva,broken-gen2: limit to gen1 speed instead of gen2.
> @@ -56,4 +60,8 @@ Examples:
> ceva,p1-burst-params = /bits/ 8 <0x0A 0x08 0x4A 0x06>;
> ceva,p1-retry-params = /bits/ 16 <0x0216 0x7F06>;
> ceva,broken-gen2;
> + phy-names = "sata-phy";
> + phys = <&psgtr 1 PHY_TYPE_SATA 1 1>;
> + reset-names = "sata_rst";
> + resets = <&zynqmp_reset ZYNQMP_RESET_SATA>;
> };
> --
> 2.7.4
>
prev parent reply other threads:[~2020-09-15 6:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 7:05 [PATCH 0/2] ata: ahci: ceva: Update the driver to support xilinx GT phy Piyush Mehta
2020-09-02 7:05 ` [PATCH 1/2] " Piyush Mehta
2020-09-02 7:05 ` [PATCH 2/2] dt-bindings: ata: achi: ceva: Update documentation for CEVA Controller Piyush Mehta
2020-09-04 7:23 ` Michal Simek
2020-09-14 20:08 ` Rob Herring
2020-09-15 6:40 ` Piyush Mehta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR02MB397553291F489C01FC8C3A88D4200@BYAPR02MB3975.namprd02.prod.outlook.com \
--to=piyushm@xilinx.com \
--cc=axboe@kernel.dk \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sgoud@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®