[PATCH v3 0/2] drm: panel-orientation-quirks: Add quirk for Steam Deck Galileo revision and re-label the Deck panel quirks to specify hardware revision

[PATCH v3 0/2] drm: panel-orientation-quirks: Add quirk for Steam Deck Galileo revision and re-label the Deck panel quirks to specify hardware revision

[Matthew Schwartz]

This is a series of 2 patches. 

The first patch is from Valve's publicly available kernel 
source tree. It adds a panel rotation quirk for Valve's Steam Deck Galileo
revision, which has an 800x1280 OLED panel. The previous Steam Deck panel
orientation quirk does not apply to the Galileo revision's DMI.

The original commit is missing a Signed-off-by: from the original author, 
although the source tree is available publicly in a compressed package 
https://steamdeck-packages.steamos.cloud/archlinux-mirror/sources/
under the linux-integration-65 name in Jupiter-Main. 
It is also on the public mirror 
https://gitlab.com/evlaV/linux-integration/-/commit/d2522d8bf as the
official SteamOS GitLab instance itself is private.

I was told this could be submitted without the original 
author's Signed-off-by: if I used Suggested-by: and Link:
Please let me know if this is incorrect.
I added my own Signed-off-by: to the first patch as I was the one who
added a commit message explaining the change. I did not change any
functional part of the patch. 

The second patch is one that I authored to clarify which
device version each panel quirk applies to now that there are
multiple Steam Deck revisions. 

---
v3: fixup inconsistent patch versioning across patches in v2
v2: fixup patch 1/2 commit message

Link to v1: https://lore.kernel.org/all/20240627175947.65513-1-mattschwartz@gwu.edu/

---
John Schoenick (1):
  drm: panel-orientation-quirks: Add quirk for Valve Galileo

Matthew Schwartz (1):
  drm: panel-orientation-quirks: Add labels for both Valve Steam Deck
    revisions

 drivers/gpu/drm/drm_panel_orientation_quirks.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

-- 
2.45.2

[PATCH v3 1/2] drm: panel-orientation-quirks: Add quirk for Valve Galileo

[Matthew Schwartz]

From: John Schoenick <johns@valvesoftware.com>

Valve's Steam Deck Galileo revision has a 800x1280 OLED panel

Suggested-by: John Schoenick <johns@valvesoftware.com>
Link: https://gitlab.com/evlaV/linux-integration/-/commit/d2522d8bf88b35a8cf6978afbbd55c80d2d53f4f
Signed-off-by: Matthew Schwartz <mattschwartz@gwu.edu>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 3d127127e7cb..ac8319d38e37 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -427,6 +427,13 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
+	}, {	/* Valve Steam Deck */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galileo"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
+		},
+		.driver_data = (void *)&lcd800x1280_rightside_up,
 	}, {	/* VIOS LTH17 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
-- 
2.45.2

Re: [PATCH v3 1/2] drm: panel-orientation-quirks: Add quirk for Valve Galileo

[Hamza Mahfooz]

On 6/27/24 16:30, Matthew Schwartz wrote:
> From: John Schoenick <johns@valvesoftware.com>

Since this patch is from John, you would need his S-o-b in here as well
(assuming you have his permission to add it).

> 
> Valve's Steam Deck Galileo revision has a 800x1280 OLED panel
> 
> Suggested-by: John Schoenick <johns@valvesoftware.com>
> Link: https://gitlab.com/evlaV/linux-integration/-/commit/d2522d8bf88b35a8cf6978afbbd55c80d2d53f4f
> Signed-off-by: Matthew Schwartz <mattschwartz@gwu.edu>
> ---
>   drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 3d127127e7cb..ac8319d38e37 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -427,6 +427,13 @@ static const struct dmi_system_id orientation_data[] = {
>   		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
>   		},
>   		.driver_data = (void *)&lcd800x1280_rightside_up,
> +	}, {	/* Valve Steam Deck */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galileo"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
> +		},
> +		.driver_data = (void *)&lcd800x1280_rightside_up,
>   	}, {	/* VIOS LTH17 */
>   		.matches = {
>   		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
-- 
Hamza

Re: [PATCH v3 1/2] drm: panel-orientation-quirks: Add quirk for Valve Galileo

[Matthew Schwartz]

On Thu, Jun 27, 2024 at 2:28 PM Hamza Mahfooz <hamza.mahfooz@amd.com> wrote:
>
> On 6/27/24 16:30, Matthew Schwartz wrote:
> > From: John Schoenick <johns@valvesoftware.com>
>
> Since this patch is from John, you would need his S-o-b in here as well
> (assuming you have his permission to add it).

This patch will be pending approval from them in that case. The panel quirk
follows the same structure as the Steam Deck Jupiter revision, but the quirk
has only been signed during merges by people who were not the original author.
Link: https://gitlab.com/evlaV/linux-integration/-/commit/b90ac393

>
> >
> > Valve's Steam Deck Galileo revision has a 800x1280 OLED panel
> >
> > Suggested-by: John Schoenick <johns@valvesoftware.com>
> > Link: https://gitlab.com/evlaV/linux-integration/-/commit/d2522d8bf88b35a8cf6978afbbd55c80d2d53f4f
> > Signed-off-by: Matthew Schwartz <mattschwartz@gwu.edu>
> > ---
> >   drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++
> >   1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > index 3d127127e7cb..ac8319d38e37 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -427,6 +427,13 @@ static const struct dmi_system_id orientation_data[] = {
> >                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
> >               },
> >               .driver_data = (void *)&lcd800x1280_rightside_up,
> > +     }, {    /* Valve Steam Deck */
> > +             .matches = {
> > +               DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
> > +               DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galileo"),
> > +               DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
> > +             },
> > +             .driver_data = (void *)&lcd800x1280_rightside_up,

Unless I get a S-o-b, is authoring a different DMI check the only solution
to get a functioning panel quirk upstreamed for the Galileo revision?
Not quite sure how I'd maintain conformity with the existing Jupiter
quirk while also writing something original here.

> >       }, {    /* VIOS LTH17 */
> >               .matches = {
> >                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
> --
> Hamza
>
--
Matt

Re: [PATCH v3 1/2] drm: panel-orientation-quirks: Add quirk for Valve Galileo

[John Schoenick]

On 6/27/24 5:17 PM, Matthew Schwartz wrote:
> On Thu, Jun 27, 2024 at 2:28 PM Hamza Mahfooz <hamza.mahfooz@amd.com> wrote:
>> On 6/27/24 16:30, Matthew Schwartz wrote:
>>> From: John Schoenick <johns@valvesoftware.com>
>> Since this patch is from John, you would need his S-o-b in here as well
>> (assuming you have his permission to add it).
> This patch will be pending approval from them in that case. The panel quirk
> follows the same structure as the Steam Deck Jupiter revision, but the quirk
> has only been signed during merges by people who were not the original author.
> Link: https://gitlab.com/evlaV/linux-integration/-/commit/b90ac393

Hey, thanks for taking the initiative to upstream this -- feel free to 
add my S-o-b

>>
>>> Valve's Steam Deck Galileo revision has a 800x1280 OLED panel
>>>
>>> Suggested-by: John Schoenick <johns@valvesoftware.com>
>>> Link: https://gitlab.com/evlaV/linux-integration/-/commit/d2522d8bf88b35a8cf6978afbbd55c80d2d53f4f
>>> Signed-off-by: Matthew Schwartz <mattschwartz@gwu.edu>
>>> ---
>>>    drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++
>>>    1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>>> index 3d127127e7cb..ac8319d38e37 100644
>>> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
>>> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>>> @@ -427,6 +427,13 @@ static const struct dmi_system_id orientation_data[] = {
>>>                  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
>>>                },
>>>                .driver_data = (void *)&lcd800x1280_rightside_up,
>>> +     }, {    /* Valve Steam Deck */
>>> +             .matches = {
>>> +               DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
>>> +               DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galileo"),
>>> +               DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
>>> +             },
>>> +             .driver_data = (void *)&lcd800x1280_rightside_up,
> Unless I get a S-o-b, is authoring a different DMI check the only solution
> to get a functioning panel quirk upstreamed for the Galileo revision?
> Not quite sure how I'd maintain conformity with the existing Jupiter
> quirk while also writing something original here.
>
>>>        }, {    /* VIOS LTH17 */
>>>                .matches = {
>>>                  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"),
>> --
>> Hamza
>>
> --
> Matt
>

[PATCH v3 2/2] drm: panel-orientation-quirks: Add labels for both Valve Steam Deck revisions

[Matthew Schwartz]

This accounts for the existence of two Steam Deck revisions 
instead of a single revision

Signed-off-by: Matthew Schwartz <mattschwartz@gwu.edu>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index ac8319d38e37..3f84d7527793 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -420,14 +420,14 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galaxy Book 10.6"),
 		},
 		.driver_data = (void *)&lcd1280x1920_rightside_up,
-	}, {	/* Valve Steam Deck */
+	}, {	/* Valve Steam Deck (Jupiter) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Jupiter"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"),
 		},
 		.driver_data = (void *)&lcd800x1280_rightside_up,
-	}, {	/* Valve Steam Deck */
+	}, {	/* Valve Steam Deck (Galileo) */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"),
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Galileo"),
-- 
2.45.2