* [PATCH] dt-bindings: pinctrl: Correct indentation and style in DTS example
@ 2025-01-07 12:58 Krzysztof Kozlowski
2025-01-09 3:01 ` Manikandan.M
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-01-07 12:58 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Nicolas Ferre, Alexandre Belloni, Claudiu Beznea, Michal Simek,
Manikandan Muralidharan, TY Chang, Krishna Potthuri, linux-gpio,
devicetree, linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski
DTS example in the bindings should be indented with 2- or 4-spaces and
aligned with opening '- |', so correct any differences like 3-spaces or
mixtures 2- and 4-spaces in one binding.
No functional changes here, but saves some comments during reviews of
new patches built on existing code.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../pinctrl/atmel,at91rm9200-pinctrl.yaml | 64 +++++++++----------
.../pinctrl/realtek,rtd1315e-pinctrl.yaml | 50 +++++++--------
.../pinctrl/realtek,rtd1319d-pinctrl.yaml | 50 +++++++--------
.../pinctrl/realtek,rtd1619b-pinctrl.yaml | 50 +++++++--------
.../bindings/pinctrl/xlnx,pinctrl-zynq.yaml | 53 +++++++--------
5 files changed, 130 insertions(+), 137 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/atmel,at91rm9200-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/atmel,at91rm9200-pinctrl.yaml
index 1bb386b42039..a7ede29c1444 100644
--- a/Documentation/devicetree/bindings/pinctrl/atmel,at91rm9200-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/atmel,at91rm9200-pinctrl.yaml
@@ -145,40 +145,40 @@ additionalProperties:
examples:
- |
- #include <dt-bindings/clock/at91.h>
- #include <dt-bindings/interrupt-controller/irq.h>
- #include <dt-bindings/pinctrl/at91.h>
+ #include <dt-bindings/clock/at91.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/pinctrl/at91.h>
- pinctrl@fffff400 {
- #address-cells = <1>;
- #size-cells = <1>;
- compatible = "atmel,at91rm9200-pinctrl", "simple-mfd";
- ranges = <0xfffff400 0xfffff400 0x600>;
+ pinctrl@fffff400 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "atmel,at91rm9200-pinctrl", "simple-mfd";
+ ranges = <0xfffff400 0xfffff400 0x600>;
- atmel,mux-mask = <
- /* A B */
- 0xffffffff 0xffc00c3b /* pioA */
- 0xffffffff 0x7fff3ccf /* pioB */
- 0xffffffff 0x007fffff /* pioC */
- >;
+ atmel,mux-mask = <
+ /* A B */
+ 0xffffffff 0xffc00c3b /* pioA */
+ 0xffffffff 0x7fff3ccf /* pioB */
+ 0xffffffff 0x007fffff /* pioC */
+ >;
- dbgu {
- pinctrl_dbgu: dbgu-0 {
- atmel,pins =
- <AT91_PIOB 14 AT91_PERIPH_A AT91_PINCTRL_PULL_UP
- AT91_PIOB 15 AT91_PERIPH_A AT91_PINCTRL_NONE>;
- };
- };
+ dbgu {
+ dbgu-0 {
+ atmel,pins =
+ <AT91_PIOB 14 AT91_PERIPH_A AT91_PINCTRL_PULL_UP
+ AT91_PIOB 15 AT91_PERIPH_A AT91_PINCTRL_NONE>;
+ };
+ };
- pioA: gpio@fffff400 {
- compatible = "atmel,at91rm9200-gpio";
- reg = <0xfffff400 0x200>;
- interrupts = <2 IRQ_TYPE_LEVEL_HIGH 1>;
- #gpio-cells = <2>;
- gpio-controller;
- interrupt-controller;
- #interrupt-cells = <2>;
- clocks = <&pmc PMC_TYPE_PERIPHERAL 2>;
- };
- };
+ gpio@fffff400 {
+ compatible = "atmel,at91rm9200-gpio";
+ reg = <0xfffff400 0x200>;
+ interrupts = <2 IRQ_TYPE_LEVEL_HIGH 1>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ clocks = <&pmc PMC_TYPE_PERIPHERAL 2>;
+ };
+ };
...
diff --git a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml
index fc6c65fea73b..90bd49d87d2e 100644
--- a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml
@@ -159,30 +159,30 @@ additionalProperties: false
examples:
- |
- pinctrl@4e000 {
- compatible = "realtek,rtd1315e-pinctrl";
- reg = <0x4e000 0x130>;
+ pinctrl@4e000 {
+ compatible = "realtek,rtd1315e-pinctrl";
+ reg = <0x4e000 0x130>;
- emmc-hs200-pins {
- pins = "emmc_clk",
- "emmc_cmd",
- "emmc_data_0",
- "emmc_data_1",
- "emmc_data_2",
- "emmc_data_3",
- "emmc_data_4",
- "emmc_data_5",
- "emmc_data_6",
- "emmc_data_7";
- function = "emmc";
- realtek,drive-strength-p = <0x2>;
- realtek,drive-strength-n = <0x2>;
- };
+ emmc-hs200-pins {
+ pins = "emmc_clk",
+ "emmc_cmd",
+ "emmc_data_0",
+ "emmc_data_1",
+ "emmc_data_2",
+ "emmc_data_3",
+ "emmc_data_4",
+ "emmc_data_5",
+ "emmc_data_6",
+ "emmc_data_7";
+ function = "emmc";
+ realtek,drive-strength-p = <0x2>;
+ realtek,drive-strength-n = <0x2>;
+ };
- i2c-0-pins {
- pins = "gpio_12",
- "gpio_13";
- function = "i2c0";
- drive-strength = <4>;
- };
- };
+ i2c-0-pins {
+ pins = "gpio_12",
+ "gpio_13";
+ function = "i2c0";
+ drive-strength = <4>;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1319d-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1319d-pinctrl.yaml
index f07361d60acd..b6211c8544ca 100644
--- a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1319d-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1319d-pinctrl.yaml
@@ -158,30 +158,30 @@ additionalProperties: false
examples:
- |
- pinctrl@4e000 {
- compatible = "realtek,rtd1319d-pinctrl";
- reg = <0x4e000 0x130>;
+ pinctrl@4e000 {
+ compatible = "realtek,rtd1319d-pinctrl";
+ reg = <0x4e000 0x130>;
- emmc-hs200-pins {
- pins = "emmc_clk",
- "emmc_cmd",
- "emmc_data_0",
- "emmc_data_1",
- "emmc_data_2",
- "emmc_data_3",
- "emmc_data_4",
- "emmc_data_5",
- "emmc_data_6",
- "emmc_data_7";
- function = "emmc";
- realtek,drive-strength-p = <0x2>;
- realtek,drive-strength-n = <0x2>;
- };
+ emmc-hs200-pins {
+ pins = "emmc_clk",
+ "emmc_cmd",
+ "emmc_data_0",
+ "emmc_data_1",
+ "emmc_data_2",
+ "emmc_data_3",
+ "emmc_data_4",
+ "emmc_data_5",
+ "emmc_data_6",
+ "emmc_data_7";
+ function = "emmc";
+ realtek,drive-strength-p = <0x2>;
+ realtek,drive-strength-n = <0x2>;
+ };
- i2c-0-pins {
- pins = "gpio_12",
- "gpio_13";
- function = "i2c0";
- drive-strength = <4>;
- };
- };
+ i2c-0-pins {
+ pins = "gpio_12",
+ "gpio_13";
+ function = "i2c0";
+ drive-strength = <4>;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1619b-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1619b-pinctrl.yaml
index 671e4ec84624..e88bc649cc73 100644
--- a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1619b-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1619b-pinctrl.yaml
@@ -157,30 +157,30 @@ additionalProperties: false
examples:
- |
- pinctrl@4e000 {
- compatible = "realtek,rtd1619b-pinctrl";
- reg = <0x4e000 0x130>;
+ pinctrl@4e000 {
+ compatible = "realtek,rtd1619b-pinctrl";
+ reg = <0x4e000 0x130>;
- emmc-hs200-pins {
- pins = "emmc_clk",
- "emmc_cmd",
- "emmc_data_0",
- "emmc_data_1",
- "emmc_data_2",
- "emmc_data_3",
- "emmc_data_4",
- "emmc_data_5",
- "emmc_data_6",
- "emmc_data_7";
- function = "emmc";
- realtek,drive-strength-p = <0x2>;
- realtek,drive-strength-n = <0x2>;
- };
+ emmc-hs200-pins {
+ pins = "emmc_clk",
+ "emmc_cmd",
+ "emmc_data_0",
+ "emmc_data_1",
+ "emmc_data_2",
+ "emmc_data_3",
+ "emmc_data_4",
+ "emmc_data_5",
+ "emmc_data_6",
+ "emmc_data_7";
+ function = "emmc";
+ realtek,drive-strength-p = <0x2>;
+ realtek,drive-strength-n = <0x2>;
+ };
- i2c-0-pins {
- pins = "gpio_12",
- "gpio_13";
- function = "i2c0";
- drive-strength = <4>;
- };
- };
+ i2c-0-pins {
+ pins = "gpio_12",
+ "gpio_13";
+ function = "i2c0";
+ drive-strength = <4>;
+ };
+ };
diff --git a/Documentation/devicetree/bindings/pinctrl/xlnx,pinctrl-zynq.yaml b/Documentation/devicetree/bindings/pinctrl/xlnx,pinctrl-zynq.yaml
index de6c10ba36c4..70548cb37ada 100644
--- a/Documentation/devicetree/bindings/pinctrl/xlnx,pinctrl-zynq.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/xlnx,pinctrl-zynq.yaml
@@ -180,38 +180,31 @@ additionalProperties: false
examples:
- |
#include <dt-bindings/pinctrl/pinctrl-zynq.h>
- pinctrl0: pinctrl@700 {
- compatible = "xlnx,pinctrl-zynq";
- reg = <0x700 0x200>;
- syscon = <&slcr>;
+ pinctrl@700 {
+ compatible = "xlnx,pinctrl-zynq";
+ reg = <0x700 0x200>;
+ syscon = <&slcr>;
- pinctrl_uart1_default: uart1-default {
- mux {
- groups = "uart1_10_grp";
- function = "uart1";
- };
+ uart1-default {
+ mux {
+ groups = "uart1_10_grp";
+ function = "uart1";
+ };
- conf {
- groups = "uart1_10_grp";
- slew-rate = <0>;
- power-source = <IO_STANDARD_LVCMOS18>;
- };
+ conf {
+ groups = "uart1_10_grp";
+ slew-rate = <0>;
+ power-source = <IO_STANDARD_LVCMOS18>;
+ };
- conf-rx {
- pins = "MIO49";
- bias-high-impedance;
- };
+ conf-rx {
+ pins = "MIO49";
+ bias-high-impedance;
+ };
- conf-tx {
- pins = "MIO48";
- bias-disable;
- };
- };
+ conf-tx {
+ pins = "MIO48";
+ bias-disable;
+ };
+ };
};
-
- uart1 {
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_uart1_default>;
- };
-
-...
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Correct indentation and style in DTS example
2025-01-07 12:58 [PATCH] dt-bindings: pinctrl: Correct indentation and style in DTS example Krzysztof Kozlowski
@ 2025-01-09 3:01 ` Manikandan.M
2025-01-10 15:41 ` Rob Herring (Arm)
2025-01-14 14:17 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Manikandan.M @ 2025-01-09 3:01 UTC (permalink / raw)
To: krzysztof.kozlowski, linus.walleij, robh, krzk+dt, conor+dt,
Nicolas.Ferre, alexandre.belloni, claudiu.beznea, michal.simek,
tychang, sai.krishna.potthuri, linux-gpio, devicetree,
linux-arm-kernel, linux-kernel
On 07/01/25 6:28 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Manikandan Muralidharan <manikandan.m@microchip.com>
> ---
> .../pinctrl/atmel,at91rm9200-pinctrl.yaml | 64 +++++++++----------
> .../pinctrl/realtek,rtd1315e-pinctrl.yaml | 50 +++++++--------
> .../pinctrl/realtek,rtd1319d-pinctrl.yaml | 50 +++++++--------
> .../pinctrl/realtek,rtd1619b-pinctrl.yaml | 50 +++++++--------
> .../bindings/pinctrl/xlnx,pinctrl-zynq.yaml | 53 +++++++--------
> 5 files changed, 130 insertions(+), 137 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/atmel,at91rm9200-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/atmel,at91rm9200-pinctrl.yaml
> index 1bb386b42039..a7ede29c1444 100644
> --- a/Documentation/devicetree/bindings/pinctrl/atmel,at91rm9200-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/atmel,at91rm9200-pinctrl.yaml
> @@ -145,40 +145,40 @@ additionalProperties:
>
> examples:
> - |
> - #include <dt-bindings/clock/at91.h>
> - #include <dt-bindings/interrupt-controller/irq.h>
> - #include <dt-bindings/pinctrl/at91.h>
> + #include <dt-bindings/clock/at91.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/pinctrl/at91.h>
>
> - pinctrl@fffff400 {
> - #address-cells = <1>;
> - #size-cells = <1>;
> - compatible = "atmel,at91rm9200-pinctrl", "simple-mfd";
> - ranges = <0xfffff400 0xfffff400 0x600>;
> + pinctrl@fffff400 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "atmel,at91rm9200-pinctrl", "simple-mfd";
> + ranges = <0xfffff400 0xfffff400 0x600>;
>
> - atmel,mux-mask = <
> - /* A B */
> - 0xffffffff 0xffc00c3b /* pioA */
> - 0xffffffff 0x7fff3ccf /* pioB */
> - 0xffffffff 0x007fffff /* pioC */
> - >;
> + atmel,mux-mask = <
> + /* A B */
> + 0xffffffff 0xffc00c3b /* pioA */
> + 0xffffffff 0x7fff3ccf /* pioB */
> + 0xffffffff 0x007fffff /* pioC */
> + >;
>
> - dbgu {
> - pinctrl_dbgu: dbgu-0 {
> - atmel,pins =
> - <AT91_PIOB 14 AT91_PERIPH_A AT91_PINCTRL_PULL_UP
> - AT91_PIOB 15 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> - };
> - };
> + dbgu {
> + dbgu-0 {
> + atmel,pins =
> + <AT91_PIOB 14 AT91_PERIPH_A AT91_PINCTRL_PULL_UP
> + AT91_PIOB 15 AT91_PERIPH_A AT91_PINCTRL_NONE>;
> + };
> + };
>
> - pioA: gpio@fffff400 {
> - compatible = "atmel,at91rm9200-gpio";
> - reg = <0xfffff400 0x200>;
> - interrupts = <2 IRQ_TYPE_LEVEL_HIGH 1>;
> - #gpio-cells = <2>;
> - gpio-controller;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - clocks = <&pmc PMC_TYPE_PERIPHERAL 2>;
> - };
> - };
> + gpio@fffff400 {
> + compatible = "atmel,at91rm9200-gpio";
> + reg = <0xfffff400 0x200>;
> + interrupts = <2 IRQ_TYPE_LEVEL_HIGH 1>;
> + #gpio-cells = <2>;
> + gpio-controller;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + clocks = <&pmc PMC_TYPE_PERIPHERAL 2>;
> + };
> + };
> ...
> diff --git a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml
> index fc6c65fea73b..90bd49d87d2e 100644
> --- a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1315e-pinctrl.yaml
> @@ -159,30 +159,30 @@ additionalProperties: false
>
> examples:
> - |
> - pinctrl@4e000 {
> - compatible = "realtek,rtd1315e-pinctrl";
> - reg = <0x4e000 0x130>;
> + pinctrl@4e000 {
> + compatible = "realtek,rtd1315e-pinctrl";
> + reg = <0x4e000 0x130>;
>
> - emmc-hs200-pins {
> - pins = "emmc_clk",
> - "emmc_cmd",
> - "emmc_data_0",
> - "emmc_data_1",
> - "emmc_data_2",
> - "emmc_data_3",
> - "emmc_data_4",
> - "emmc_data_5",
> - "emmc_data_6",
> - "emmc_data_7";
> - function = "emmc";
> - realtek,drive-strength-p = <0x2>;
> - realtek,drive-strength-n = <0x2>;
> - };
> + emmc-hs200-pins {
> + pins = "emmc_clk",
> + "emmc_cmd",
> + "emmc_data_0",
> + "emmc_data_1",
> + "emmc_data_2",
> + "emmc_data_3",
> + "emmc_data_4",
> + "emmc_data_5",
> + "emmc_data_6",
> + "emmc_data_7";
> + function = "emmc";
> + realtek,drive-strength-p = <0x2>;
> + realtek,drive-strength-n = <0x2>;
> + };
>
> - i2c-0-pins {
> - pins = "gpio_12",
> - "gpio_13";
> - function = "i2c0";
> - drive-strength = <4>;
> - };
> - };
> + i2c-0-pins {
> + pins = "gpio_12",
> + "gpio_13";
> + function = "i2c0";
> + drive-strength = <4>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1319d-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1319d-pinctrl.yaml
> index f07361d60acd..b6211c8544ca 100644
> --- a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1319d-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1319d-pinctrl.yaml
> @@ -158,30 +158,30 @@ additionalProperties: false
>
> examples:
> - |
> - pinctrl@4e000 {
> - compatible = "realtek,rtd1319d-pinctrl";
> - reg = <0x4e000 0x130>;
> + pinctrl@4e000 {
> + compatible = "realtek,rtd1319d-pinctrl";
> + reg = <0x4e000 0x130>;
>
> - emmc-hs200-pins {
> - pins = "emmc_clk",
> - "emmc_cmd",
> - "emmc_data_0",
> - "emmc_data_1",
> - "emmc_data_2",
> - "emmc_data_3",
> - "emmc_data_4",
> - "emmc_data_5",
> - "emmc_data_6",
> - "emmc_data_7";
> - function = "emmc";
> - realtek,drive-strength-p = <0x2>;
> - realtek,drive-strength-n = <0x2>;
> - };
> + emmc-hs200-pins {
> + pins = "emmc_clk",
> + "emmc_cmd",
> + "emmc_data_0",
> + "emmc_data_1",
> + "emmc_data_2",
> + "emmc_data_3",
> + "emmc_data_4",
> + "emmc_data_5",
> + "emmc_data_6",
> + "emmc_data_7";
> + function = "emmc";
> + realtek,drive-strength-p = <0x2>;
> + realtek,drive-strength-n = <0x2>;
> + };
>
> - i2c-0-pins {
> - pins = "gpio_12",
> - "gpio_13";
> - function = "i2c0";
> - drive-strength = <4>;
> - };
> - };
> + i2c-0-pins {
> + pins = "gpio_12",
> + "gpio_13";
> + function = "i2c0";
> + drive-strength = <4>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1619b-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1619b-pinctrl.yaml
> index 671e4ec84624..e88bc649cc73 100644
> --- a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1619b-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1619b-pinctrl.yaml
> @@ -157,30 +157,30 @@ additionalProperties: false
>
> examples:
> - |
> - pinctrl@4e000 {
> - compatible = "realtek,rtd1619b-pinctrl";
> - reg = <0x4e000 0x130>;
> + pinctrl@4e000 {
> + compatible = "realtek,rtd1619b-pinctrl";
> + reg = <0x4e000 0x130>;
>
> - emmc-hs200-pins {
> - pins = "emmc_clk",
> - "emmc_cmd",
> - "emmc_data_0",
> - "emmc_data_1",
> - "emmc_data_2",
> - "emmc_data_3",
> - "emmc_data_4",
> - "emmc_data_5",
> - "emmc_data_6",
> - "emmc_data_7";
> - function = "emmc";
> - realtek,drive-strength-p = <0x2>;
> - realtek,drive-strength-n = <0x2>;
> - };
> + emmc-hs200-pins {
> + pins = "emmc_clk",
> + "emmc_cmd",
> + "emmc_data_0",
> + "emmc_data_1",
> + "emmc_data_2",
> + "emmc_data_3",
> + "emmc_data_4",
> + "emmc_data_5",
> + "emmc_data_6",
> + "emmc_data_7";
> + function = "emmc";
> + realtek,drive-strength-p = <0x2>;
> + realtek,drive-strength-n = <0x2>;
> + };
>
> - i2c-0-pins {
> - pins = "gpio_12",
> - "gpio_13";
> - function = "i2c0";
> - drive-strength = <4>;
> - };
> - };
> + i2c-0-pins {
> + pins = "gpio_12",
> + "gpio_13";
> + function = "i2c0";
> + drive-strength = <4>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/pinctrl/xlnx,pinctrl-zynq.yaml b/Documentation/devicetree/bindings/pinctrl/xlnx,pinctrl-zynq.yaml
> index de6c10ba36c4..70548cb37ada 100644
> --- a/Documentation/devicetree/bindings/pinctrl/xlnx,pinctrl-zynq.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/xlnx,pinctrl-zynq.yaml
> @@ -180,38 +180,31 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/pinctrl/pinctrl-zynq.h>
> - pinctrl0: pinctrl@700 {
> - compatible = "xlnx,pinctrl-zynq";
> - reg = <0x700 0x200>;
> - syscon = <&slcr>;
> + pinctrl@700 {
> + compatible = "xlnx,pinctrl-zynq";
> + reg = <0x700 0x200>;
> + syscon = <&slcr>;
>
> - pinctrl_uart1_default: uart1-default {
> - mux {
> - groups = "uart1_10_grp";
> - function = "uart1";
> - };
> + uart1-default {
> + mux {
> + groups = "uart1_10_grp";
> + function = "uart1";
> + };
>
> - conf {
> - groups = "uart1_10_grp";
> - slew-rate = <0>;
> - power-source = <IO_STANDARD_LVCMOS18>;
> - };
> + conf {
> + groups = "uart1_10_grp";
> + slew-rate = <0>;
> + power-source = <IO_STANDARD_LVCMOS18>;
> + };
>
> - conf-rx {
> - pins = "MIO49";
> - bias-high-impedance;
> - };
> + conf-rx {
> + pins = "MIO49";
> + bias-high-impedance;
> + };
>
> - conf-tx {
> - pins = "MIO48";
> - bias-disable;
> - };
> - };
> + conf-tx {
> + pins = "MIO48";
> + bias-disable;
> + };
> + };
> };
> -
> - uart1 {
> - pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_uart1_default>;
> - };
> -
> -...
> --
> 2.43.0
>
--
Thanks and Regards,
Manikandan M.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Correct indentation and style in DTS example
2025-01-07 12:58 [PATCH] dt-bindings: pinctrl: Correct indentation and style in DTS example Krzysztof Kozlowski
2025-01-09 3:01 ` Manikandan.M
@ 2025-01-10 15:41 ` Rob Herring (Arm)
2025-01-14 14:17 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-01-10 15:41 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Conor Dooley, linux-arm-kernel, linux-gpio, Nicolas Ferre,
devicetree, Manikandan Muralidharan, Claudiu Beznea,
Krzysztof Kozlowski, Krishna Potthuri, Alexandre Belloni,
linux-kernel, TY Chang, Michal Simek, Linus Walleij
On Tue, 07 Jan 2025 13:58:34 +0100, Krzysztof Kozlowski wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../pinctrl/atmel,at91rm9200-pinctrl.yaml | 64 +++++++++----------
> .../pinctrl/realtek,rtd1315e-pinctrl.yaml | 50 +++++++--------
> .../pinctrl/realtek,rtd1319d-pinctrl.yaml | 50 +++++++--------
> .../pinctrl/realtek,rtd1619b-pinctrl.yaml | 50 +++++++--------
> .../bindings/pinctrl/xlnx,pinctrl-zynq.yaml | 53 +++++++--------
> 5 files changed, 130 insertions(+), 137 deletions(-)
>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: Correct indentation and style in DTS example
2025-01-07 12:58 [PATCH] dt-bindings: pinctrl: Correct indentation and style in DTS example Krzysztof Kozlowski
2025-01-09 3:01 ` Manikandan.M
2025-01-10 15:41 ` Rob Herring (Arm)
@ 2025-01-14 14:17 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2025-01-14 14:17 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Nicolas Ferre,
Alexandre Belloni, Claudiu Beznea, Michal Simek,
Manikandan Muralidharan, TY Chang, Krishna Potthuri, linux-gpio,
devicetree, linux-arm-kernel, linux-kernel
On Tue, Jan 7, 2025 at 1:58 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks Krzysztof, patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-01-14 14:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-07 12:58 [PATCH] dt-bindings: pinctrl: Correct indentation and style in DTS example Krzysztof Kozlowski
2025-01-09 3:01 ` Manikandan.M
2025-01-10 15:41 ` Rob Herring (Arm)
2025-01-14 14:17 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®