mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Christian Hewitt <christianshewitt@gmail.com>
Cc: Qiang Yu <yuq825@gmail.com>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org, lima@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Steven Price <steven.price@arm.com>
Subject: Re: [PATCH] drm/lima: add governor data with pre-defined thresholds
Date: Wed, 27 Jan 2021 11:11:14 +0000	[thread overview]
Message-ID: <88ae6467-07fc-2c4e-9db9-a02a00d01347@arm.com> (raw)
In-Reply-To: <9e30a8e1-ef69-5929-17f1-cdb603686495@arm.com>



On 1/27/21 10:24 AM, Lukasz Luba wrote:
> Hi Christian,
> 
> On 1/25/21 8:18 AM, Christian Hewitt wrote:
>> This patch adapts the panfrost pre-defined thresholds change [0] to the
>> lima driver to improve real-world performance. The upthreshold value has
>> been set to ramp GPU frequency to max freq faster (compared to panfrost)
>> to compensate for the lower overall performance of utgard devices.
>>
>> [0] 
>> https://patchwork.kernel.org/project/dri-devel/patch/20210121170445.19761-1-lukasz.luba@arm.com/ 
>>
>>
>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>> ---
>> I have been using Kodi as my test application. If you scroll in library
>> views with hundreds of list items and the panfrost values the slow GPU
>> ramp up is quite noticeable and the GUI feels sluggish. As everything
>> lima runs on is inherently slower than panfrost using devices I believe
>> it's better to ramp up to max freq quicker.
> 
> It's quite low value for the upthreshold, but I believe you have
> experimented and observed that a bit higher (30, 40?) don't work well.
> I don't know the Kodi system, though.
> 
> You can check if the other frequencies are also used in statistics for
> devfreq device:
> cat /sys/class/devfreq/<your_gpu>/trans_stats
> 
> If they are also used, then it OK (better than stuck at min freq).

I've just realized that your board might suffer a another issue.
Please apply this patch [1] and run your experiments with upthresholds.


[1] https://lore.kernel.org/lkml/20210127105121.20345-1-lukasz.luba@arm.com/

  reply	other threads:[~2021-01-27 11:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25  8:18 Christian Hewitt
2021-01-27 10:24 ` Lukasz Luba
2021-01-27 11:11   ` Lukasz Luba [this message]
2021-01-27 19:35     ` Christian Hewitt
2021-01-28 10:01       ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88ae6467-07fc-2c4e-9db9-a02a00d01347@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=airlied@linux.ie \
    --cc=christianshewitt@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=lima@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steven.price@arm.com \
    --cc=yuq825@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®