From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
tglx@linutronix.de, ludovic.barre@st.com
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] clocksource: stm32: convert driver to timer_of
Date: Tue, 17 Oct 2017 19:09:14 +0200 [thread overview]
Message-ID: <88c8f124-4cb1-a982-d4a2-c029ab0dcd2a@linaro.org> (raw)
In-Reply-To: <1506959513-16851-2-git-send-email-benjamin.gaignard@linaro.org>
On 02/10/2017 17:51, Benjamin Gaignard wrote:
> Convert driver to use timer_of helpers. This allow to remove
> custom proprietary structure.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> ---
[ ... ]
> - clockevents_config_and_register(&data->evtdev,
> - DIV_ROUND_CLOSEST(rate, prescaler),
> - 0x1, max_delta);
> -
> - ret = request_irq(irq, stm32_clock_event_handler, IRQF_TIMER,
> - "stm32 clockevent", data);
> - if (ret) {
> - pr_err("%pOF: failed to request irq.\n", np);
> - goto err_get_irq;
> - }
> + clockevents_config_and_register(&to->clkevt,
> + timer_of_period(to), 0x60, max_delta);
Why 0x1 -> 0x60 ?
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2017-10-17 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 15:51 [PATCH v4 0/4] stm32 clocksource driver rework Benjamin Gaignard
2017-10-02 15:51 ` [PATCH v4 1/4] clocksource: stm32: convert driver to timer_of Benjamin Gaignard
2017-10-17 17:09 ` Daniel Lezcano [this message]
2017-10-17 17:34 ` Benjamin Gaignard
2017-10-17 17:53 ` Daniel Lezcano
2017-10-02 15:51 ` [PATCH v4 2/4] clocksource: stm32: only use 32 bits timers Benjamin Gaignard
2017-10-02 15:51 ` [PATCH v4 3/4] clocksource: stm32: add clocksource support Benjamin Gaignard
2017-10-02 15:51 ` [PATCH v4 4/4] arm: dts: stm32: remove useless clocksource nodes Benjamin Gaignard
2017-10-09 9:23 ` [PATCH v4 0/4] stm32 clocksource driver rework Benjamin Gaignard
2017-10-09 9:27 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88c8f124-4cb1-a982-d4a2-c029ab0dcd2a@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ludovic.barre@st.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®