From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Xin Xu <xxsemail@qq.com>
Cc: andersson@kernel.org, devicetree@vger.kernel.org,
konradybcio@kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sm8250-xiaomi-elish: Add pm8008 PMIC
Date: Wed, 24 Jun 2026 13:00:25 +0200 [thread overview]
Message-ID: <891015c8-68df-4654-b1e7-94d73e74267c@oss.qualcomm.com> (raw)
In-Reply-To: <tencent_A1865527015C7AD1B52C56A46AD106234508@qq.com>
On 6/22/26 8:07 PM, Xin Xu wrote:
> On Mon, 2026-06-22 at 13:40 +0200, Konrad Dybcio wrote:
>> On 6/19/26 6:07 PM, Xin Xu wrote:
>>> Add the pm8008 PMIC node on i2c15 with seven LDOs,
>>> using GPIO84 as interrupt and GPIO76 as reset.
>>>
>>> Signed-off-by: Xin Xu <xxsemail@qq.com>
>>> ---
[...]
>>> + pm8008_default: pm8008-default-state {
>>> + int-pins {
>>> + pins = "gpio84";
>>> + function = "gpio";
>>> + bias-disable;
>>> + drive-strength = <2>;
>>> + input-enable;
>>> + };
>>> +
>>> + reset-pins {
>>> + pins = "gpio76";
>>> + function = "gpio";
>>> + bias-pull-up;
>>> + drive-strength = <2>;
>>> + output-high;
>>
>> Drop output-high, the driver will take care of setting the output
>> state
>>
>> Konrad
>
> Thank you for your review!
>
> I will fix the coding style issues (blank line before status,
> interrupts-extended, property order, and dropping output-high)
> in the next version.
>
> I have verified all LDO voltages against the downstream device tree:
> https://github.com/MiCode/kernel_devicetree/tree/elish-r-oss/
> The definitions can be found around lines 209–244 in
> qcom/elish-sm8250-camera-board.dtsi
Thanks. It's best if you grab the DTB from a running device (which
has all the overlays applied etc.), which you can grab from
/sys/firmware/fdt
You can then pass that to DTC directly
Konrad
next prev parent reply other threads:[~2026-06-24 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 16:07 Xin Xu
2026-06-22 11:40 ` Konrad Dybcio
2026-06-22 18:07 ` Xin Xu
2026-06-24 11:00 ` Konrad Dybcio [this message]
2026-06-25 10:07 ` Xin Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=891015c8-68df-4654-b1e7-94d73e74267c@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xxsemail@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®