[PATCH 1/2] platform/x86: acer-wmi: allow hwmon without predator_v4

[PATCH 1/2] platform/x86: acer-wmi: allow hwmon without predator_v4

[Mohsen Tahmasebi]

Some Acer laptops expose the same WMI sensor interface without necessarily
supporting other predator_v4 features.
Currently, ACER_CAP_HWMON is enabled only through predator_v4 quirk, but
this quirk enables both ACER_CAP_PLATFORM_PROFILE and ACER_CAP_HWMON.

This commit adds a separate hwmon quirk so ACER_CAP_HWMON can be enabled
without other predator_v4 features.

Signed-off-by: Mohsen Tahmasebi <moh53n@moh53n.net>
---
 drivers/platform/x86/acer-wmi.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index e0eaaefb13d..83448561189 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -403,6 +403,7 @@ struct quirk_entry {
 	u8 turbo;
 	u8 cpu_fans;
 	u8 gpu_fans;
+	u8 hwmon;
 	u8 predator_v4;
 	u8 pwm;
 };
@@ -421,6 +422,9 @@ static void __init set_quirks(void)
 		interface->capability |= ACER_CAP_TURBO_OC | ACER_CAP_TURBO_LED
 					 | ACER_CAP_TURBO_FAN;
 
+	if (quirks->hwmon)
+		interface->capability |= ACER_CAP_HWMON;
+
 	if (quirks->predator_v4)
 		interface->capability |= ACER_CAP_PLATFORM_PROFILE |
 					 ACER_CAP_HWMON;

base-commit: 3d6d817622b0a9721e3cc404df3469171582be13
-- 
2.54.0

[PATCH 2/2] platform/x86: acer-wmi: enable hwmon on Aspire A315-58G

[Mohsen Tahmasebi]

The Acer Aspire A315-58G supports the Acer hwmon interface and reports
CPU, GPU and external temperatures.
Note that the GPU temperature reports 0 when the Nvidia MX350 GPU is in
D3cold, but reports a valid value when the GPU is in D3hot/D0.

This commit enables hwmon for this model.

Signed-off-by: Mohsen Tahmasebi <moh53n@moh53n.net>
---

Tested on Acer Aspire A315-58G (BIOS V1.35).

With this series applied and MX350 GPU in D3hot:

  $ cat /sys/class/dmi/id/sys_vendor
  Acer

  $ cat /sys/class/dmi/id/product_name
  Aspire A315-58G

  $ sensors
  ...
  acer-isa-0ace
  Adapter: ISA adapter
  temp1:        +57.0°C
  temp2:        +50.0°C
  temp3:        +56.0°C
  ...

Sensor mapping:
  temp1: CPU temperature
  temp2: GPU temperature
  temp3: external temperature


 drivers/platform/x86/acer-wmi.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 83448561189..d251752d51e 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -455,6 +455,10 @@ static struct quirk_entry quirk_acer_aspire_1520 = {
 	.brightness = -1,
 };
 
+static struct quirk_entry quirk_acer_aspire_a315_58g = {
+	.hwmon = 1,
+};
+
 static struct quirk_entry quirk_acer_travelmate_2490 = {
 	.mailled = 1,
 };
@@ -639,6 +643,15 @@ static const struct dmi_system_id acer_quirks[] __initconst = {
 		},
 		.driver_data = &quirk_acer_travelmate_2490,
 	},
+	{
+		.callback = dmi_matched,
+		.ident = "Acer Aspire A315-58G",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire A315-58G"),
+		},
+		.driver_data = &quirk_acer_aspire_a315_58g,
+	},
 	{
 		.callback = dmi_matched,
 		.ident = "Acer TravelMate 2490",
-- 
2.54.0

Re: [PATCH 1/2] platform/x86: acer-wmi: allow hwmon without predator_v4

[Ilpo Järvinen]

On Thu, 13 Aug 2026, Mohsen Tahmasebi wrote:

> Some Acer laptops expose the same WMI sensor interface without necessarily
> supporting other predator_v4 features.
> Currently, ACER_CAP_HWMON is enabled only through predator_v4 quirk, but
> this quirk enables both ACER_CAP_PLATFORM_PROFILE and ACER_CAP_HWMON.
> 
> This commit adds a separate hwmon quirk so ACER_CAP_HWMON can be enabled
> without other predator_v4 features.
> 
> Signed-off-by: Mohsen Tahmasebi <moh53n@moh53n.net>
> ---
>  drivers/platform/x86/acer-wmi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index e0eaaefb13d..83448561189 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -403,6 +403,7 @@ struct quirk_entry {
>  	u8 turbo;
>  	u8 cpu_fans;
>  	u8 gpu_fans;
> +	u8 hwmon;

Hi,

Thanks for the patch.

Why is this u8? This should be bool.

Some others should have been too. If you want (not mandatory), you could 
add patches to your series to convert the other as well when prepare v2 
of the series.

>  	u8 predator_v4;
>  	u8 pwm;
>  };
> @@ -421,6 +422,9 @@ static void __init set_quirks(void)
>  		interface->capability |= ACER_CAP_TURBO_OC | ACER_CAP_TURBO_LED
>  					 | ACER_CAP_TURBO_FAN;
>  
> +	if (quirks->hwmon)
> +		interface->capability |= ACER_CAP_HWMON;
> +
>  	if (quirks->predator_v4)
>  		interface->capability |= ACER_CAP_PLATFORM_PROFILE |
>  					 ACER_CAP_HWMON;

Please properly split .hwmon completely out of .predator_v4 so that quirk 
entries that have .predator_v4 also use .hwmon.

I'm on the borderline if also .predator_v4 should be renamed to something 
related to platform profile.

-- 
 i.