From: Neil Armstrong <neil.armstrong@linaro.org>
To: Ricardo Pardini <ricardo@pardini.net>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: amlogic: add the type-c controller on Radxa Zero 2
Date: Thu, 15 Jan 2026 15:05:37 +0100 [thread overview]
Message-ID: <89634869-7858-45b7-bc2c-81436e028b83@linaro.org> (raw)
In-Reply-To: <1f256bf2-2739-4785-88fd-25101df9dad9@pardini.net>
On 1/15/26 14:59, Ricardo Pardini wrote:
> Hi Neil,
>
> On 15/01/2026 14:00, Neil Armstrong wrote:
>
>>> The Radxa Zero2 has an FUSB302 controller on i2c3 at address 0x22 and
>>> INT# wired to GPIOA-13.
>>>
>>> + interrupts = <13 IRQ_TYPE_LEVEL_LOW>;
>>
>> OK it seems I did read too fast, this should be 74 !
>>
>> S922X Datasheet (same as A311D for this)
>>
>> Table 6-32 GPIO Interrupt Sources
>>
>> ---------------------------------------------
>> | Input Mux Location | Description |
>> ---------------------------------------------
>> | [76:61] | gpioA[15:0] |
>> ---------------------------------------------
>>
>> So gpioA13 ==> 74
>
> Indeed. Sorry for this.
>
>>> +
>>> + vbus-supply = <&ao_5v>;
>>> +
>>> + status = "okay";
>>
>> And I get:
>>
>> DTC [C] arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dtb
>> arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dtb: fusb302@22 (fcs,fusb302): 'connector' is a required property
>> from schema $id: http://devicetree.org/schemas/usb/ fcs,fusb302.yaml#
>>
>> Please add a minimal connector, like:
>>
>> + connector {
>> + compatible = "usb-c-connector";
>> + label = "USB-C";
>> + data-role = "host";
>> + power-role = "source";
>> + source-pdos = <PDO_FIXED(5000, 2000, PDO_FIXED_USB_COMM)>;
>> + };
>>
>> I'll drop this change from my tree.
>
> Again, my bad. My intention here was a "minimal" description, mostly to reserve 0x22 so end-users can run `i2cdetect` or such on the 40-pin exposed i2c3 and not be surprised. Guess I didn't run dtbs_check hard enough and missed the required connector.
>
>>
>> And you may also add support for the superspeed mux to switch the USB3 polarity.
>>
>> I have a prototype at https://gitlab.com/superna9999/linux/-/tree/topic/ amlogic/radxa-zero2/fusb302?ref_type=heads
>
> I'll try your prototype. I had no idea it actually had those capabilities.
>
> Do you think it is worth to resend this with just the fixed 74 pin & the minimal connector as you suggested? Now that I've seen your work, a "add FUSB302" that does nothing (while being capable) feels frivolous and confusing.
Yes please resent with the interrupt fix and minimal connector, I'll rebase my work on top. It still needs some testing, but I'll be happy if you test it on your side aswell.
Neil
>
> Thanks,
> Ricardo
>
>
>
next prev parent reply other threads:[~2026-01-15 14:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 22:48 [PATCH 0/2] NPU and i2c3 + FUSB302 addition for " Ricardo Pardini via B4 Relay
2026-01-14 22:48 ` [PATCH 1/2] arm64: dts: amlogic: Enable the npu node on " Ricardo Pardini via B4 Relay
2026-01-14 22:48 ` [PATCH 2/2] arm64: dts: amlogic: add the type-c controller " Ricardo Pardini via B4 Relay
2026-01-15 13:00 ` Neil Armstrong
2026-01-15 13:59 ` Ricardo Pardini
2026-01-15 14:05 ` Neil Armstrong [this message]
2026-01-15 14:29 ` Krzysztof Kozlowski
2026-01-15 8:02 ` [PATCH 0/2] NPU and i2c3 + FUSB302 addition for " Neil Armstrong
2026-01-15 8:06 ` Neil Armstrong
2026-01-16 16:56 ` Krzysztof Kozlowski
2026-01-19 9:04 ` Neil Armstrong
2026-01-15 18:42 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89634869-7858-45b7-bc2c-81436e028b83@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=ricardo@pardini.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®