* [PATCH] leds: aw2013: Select REGMAP_I2C
@ 2023-11-03 11:42 Dang Huynh
2023-11-03 11:59 ` Nikita Travkin
2023-11-23 10:59 ` (subset) " Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Dang Huynh @ 2023-11-03 11:42 UTC (permalink / raw)
To: Dang Huynh
Cc: Nikita Travkin, Pavel Machek, Lee Jones, linux-leds, linux-kernel
The AW2013 driver uses devm_regmap_init_i2c, so REGMAP_I2C needs to
be selected.
Otherwise build process may fail with:
ld: drivers/leds/leds-aw2013.o: in function `aw2013_probe':
leds-aw2013.c:345: undefined reference to `__devm_regmap_init_i2c'
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
drivers/leds/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index b92208eccdea..3132439f99e0 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -110,6 +110,7 @@ config LEDS_AW200XX
config LEDS_AW2013
tristate "LED support for Awinic AW2013"
depends on LEDS_CLASS && I2C && OF
+ select REGMAP_I2C
help
This option enables support for the AW2013 3-channel
LED driver.
--
2.42.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: aw2013: Select REGMAP_I2C
2023-11-03 11:42 [PATCH] leds: aw2013: Select REGMAP_I2C Dang Huynh
@ 2023-11-03 11:59 ` Nikita Travkin
2023-11-23 10:59 ` (subset) " Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Nikita Travkin @ 2023-11-03 11:59 UTC (permalink / raw)
To: Dang Huynh; +Cc: Pavel Machek, Lee Jones, linux-leds, linux-kernel
Dang Huynh писал(а) 03.11.2023 16:42:
> The AW2013 driver uses devm_regmap_init_i2c, so REGMAP_I2C needs to
> be selected.
>
> Otherwise build process may fail with:
> ld: drivers/leds/leds-aw2013.o: in function `aw2013_probe':
> leds-aw2013.c:345: undefined reference to `__devm_regmap_init_i2c'
>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
Oh, thanks for noticing that!
Acked-by: Nikita Travkin <nikita@trvn.ru>
Btw for fixes like this it's customary to add a Fixes tag
to let stable team know they might want to backport it:
Fixes: 59ea3c9faf32 ("leds: add aw2013 driver")
> ---
> drivers/leds/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index b92208eccdea..3132439f99e0 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -110,6 +110,7 @@ config LEDS_AW200XX
> config LEDS_AW2013
> tristate "LED support for Awinic AW2013"
> depends on LEDS_CLASS && I2C && OF
> + select REGMAP_I2C
> help
> This option enables support for the AW2013 3-channel
> LED driver.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH] leds: aw2013: Select REGMAP_I2C
2023-11-03 11:42 [PATCH] leds: aw2013: Select REGMAP_I2C Dang Huynh
2023-11-03 11:59 ` Nikita Travkin
@ 2023-11-23 10:59 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2023-11-23 10:59 UTC (permalink / raw)
To: Dang Huynh; +Cc: Nikita Travkin, Pavel Machek, linux-leds, linux-kernel
On Fri, 03 Nov 2023 18:42:03 +0700, Dang Huynh wrote:
> The AW2013 driver uses devm_regmap_init_i2c, so REGMAP_I2C needs to
> be selected.
>
> Otherwise build process may fail with:
> ld: drivers/leds/leds-aw2013.o: in function `aw2013_probe':
> leds-aw2013.c:345: undefined reference to `__devm_regmap_init_i2c'
>
> [...]
Applied, thanks!
[1/1] leds: aw2013: Select REGMAP_I2C
commit: 5de5423bb5f7c1a20f00a0f45ca38e533714fcfd
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-23 10:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-03 11:42 [PATCH] leds: aw2013: Select REGMAP_I2C Dang Huynh
2023-11-03 11:59 ` Nikita Travkin
2023-11-23 10:59 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®