[PATCH] drm: writeback: Fix kernel doc name

[PATCH] drm: writeback: Fix kernel doc name

[Louis Chauvet]

During the creation of drmm_ variants for writeback connector, one
function was renamed, but not the kernel doc.

To remove the warning, use the proper name in kernel doc.

Fixes: 135d8fc7af44 ("drm: writeback: Create an helper for drm_writeback_connector initialization")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/all/20250207142201.550ce870@canb.auug.org.au/
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
Hi,

I don't know the process to merge fixes for commits in linux-next. If I
should apply this patch, where should I it be? drm-misc-next-fixes and
drm-fixes does not contains the problematic patch.

Thanks,
Louis Chauvet
---
 drivers/gpu/drm/drm_writeback.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c
index 3628fbef77524a7390b3929896a20f1c0a82117d..b14dafe765a148bbde70fcfd1a49cfea9baa9fea 100644
--- a/drivers/gpu/drm/drm_writeback.c
+++ b/drivers/gpu/drm/drm_writeback.c
@@ -213,7 +213,7 @@ static void delete_writeback_properties(struct drm_device *dev)
 }
 
 /**
- * drm_writeback_connector_init_with_encoder - Initialize a writeback connector with
+ * __drm_writeback_connector_init - Initialize a writeback connector with
  * a custom encoder
  *
  * @dev: DRM device

---
base-commit: 2eca617f12586abff62038db1c14cb3aa60a15aa
change-id: 20250207-b4-fix-warning-431e0a7067ae

Best regards,
-- 
Louis Chauvet <louis.chauvet@bootlin.com>

Re: [PATCH] drm: writeback: Fix kernel doc name

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]

Hi Louis,

On Fri, 07 Feb 2025 18:35:22 +0100 Louis Chauvet <louis.chauvet@bootlin.com> wrote:
>
> During the creation of drmm_ variants for writeback connector, one
> function was renamed, but not the kernel doc.
> 
> To remove the warning, use the proper name in kernel doc.
> 
> Fixes: 135d8fc7af44 ("drm: writeback: Create an helper for drm_writeback_connector initialization")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/all/20250207142201.550ce870@canb.auug.org.au/
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
> ---
> Hi,
> 
> I don't know the process to merge fixes for commits in linux-next. If I
> should apply this patch, where should I it be? drm-misc-next-fixes and
> drm-fixes does not contains the problematic patch.

The above commit (135d8fc7af44) is (or was yesterday) in the drm-misc
tree in linux-next
(https://gitlab.freedesktop.org/drm/misc/kernel.git#for-linux-next).

So this fix should be applied to that branch/tree.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] drm: writeback: Fix kernel doc name

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

On Fri, Feb 07, 2025 at 06:35:22PM +0100, Louis Chauvet wrote:
> During the creation of drmm_ variants for writeback connector, one
> function was renamed, but not the kernel doc.
> 
> To remove the warning, use the proper name in kernel doc.
> 
> Fixes: 135d8fc7af44 ("drm: writeback: Create an helper for drm_writeback_connector initialization")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/all/20250207142201.550ce870@canb.auug.org.au/
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
> ---
> Hi,
> 
> I don't know the process to merge fixes for commits in linux-next. If I
> should apply this patch, where should I it be? drm-misc-next-fixes and
> drm-fixes does not contains the problematic patch.

You need to apply it to drm-misc-next. The branch linux-next uses is a
merge of drm-misc-fixes, drm-misc-next, and drm-misc-next-fixes based on
when we are in the release cycle

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

Re: [PATCH] drm: writeback: Fix kernel doc name

[Louis Chauvet]

Le 07/02/2025 à 18:35, Louis Chauvet a écrit :
> During the creation of drmm_ variants for writeback connector, one
> function was renamed, but not the kernel doc.
> 
> To remove the warning, use the proper name in kernel doc.
> 
> Fixes: 135d8fc7af44 ("drm: writeback: Create an helper for drm_writeback_connector initialization")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/all/20250207142201.550ce870@canb.auug.org.au/
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>

Hi all,

Gentle ping on this patch. Can someone ack/review it so I can apply it 
on drm-misc-next?

Thanks,
Louis Chauvet

> ---
>   drivers/gpu/drm/drm_writeback.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writeback.c
> index 3628fbef77524a7390b3929896a20f1c0a82117d..b14dafe765a148bbde70fcfd1a49cfea9baa9fea 100644
> --- a/drivers/gpu/drm/drm_writeback.c
> +++ b/drivers/gpu/drm/drm_writeback.c
> @@ -213,7 +213,7 @@ static void delete_writeback_properties(struct drm_device *dev)
>   }
>   
>   /**
> - * drm_writeback_connector_init_with_encoder - Initialize a writeback connector with
> + * __drm_writeback_connector_init - Initialize a writeback connector with
>    * a custom encoder
>    *
>    * @dev: DRM device
> 
> ---
> base-commit: 2eca617f12586abff62038db1c14cb3aa60a15aa
> change-id: 20250207-b4-fix-warning-431e0a7067ae
> 
> Best regards,

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH] drm: writeback: Fix kernel doc name

[Dmitry Baryshkov]

On Thu, Feb 20, 2025 at 01:51:37PM +0100, Louis Chauvet wrote:
> 
> 
> Le 07/02/2025 à 18:35, Louis Chauvet a écrit :
> > During the creation of drmm_ variants for writeback connector, one
> > function was renamed, but not the kernel doc.
> > 
> > To remove the warning, use the proper name in kernel doc.
> > 
> > Fixes: 135d8fc7af44 ("drm: writeback: Create an helper for drm_writeback_connector initialization")
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Closes: https://lore.kernel.org/all/20250207142201.550ce870@canb.auug.org.au/
> > Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
> 
> Hi all,
> 
> Gentle ping on this patch. Can someone ack/review it so I can apply it on
> drm-misc-next?

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>



-- 
With best wishes
Dmitry

Re: [PATCH] drm: writeback: Fix kernel doc name

[Louis Chauvet]

Le 20/02/2025 à 14:49, Dmitry Baryshkov a écrit :
> On Thu, Feb 20, 2025 at 01:51:37PM +0100, Louis Chauvet wrote:
>>
>>
>> Le 07/02/2025 à 18:35, Louis Chauvet a écrit :
>>> During the creation of drmm_ variants for writeback connector, one
>>> function was renamed, but not the kernel doc.
>>>
>>> To remove the warning, use the proper name in kernel doc.
>>>
>>> Fixes: 135d8fc7af44 ("drm: writeback: Create an helper for drm_writeback_connector initialization")
>>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>>> Closes: https://lore.kernel.org/all/20250207142201.550ce870@canb.auug.org.au/
>>> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
>>
>> Hi all,
>>
>> Gentle ping on this patch. Can someone ack/review it so I can apply it on
>> drm-misc-next?
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Thanks,
Applied on drm-misc-next!

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com