mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <perex@perex.cz>, <tiwai@suse.com>,
	<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: tas2562: Return invalid for when bitwidth is invalid
Date: Tue, 18 Feb 2020 12:52:20 -0600	[thread overview]
Message-ID: <89e205b4-ba03-8db6-ff75-acec3d954b52@ti.com> (raw)
In-Reply-To: <20200218184832.GL4232@sirena.org.uk>

Mark
On 2/18/20 12:48 PM, Mark Brown wrote:
> On Tue, Feb 18, 2020 at 11:47:06AM -0600, Dan Murphy wrote:
>> If the bitwidth passed in to the set_bitwidth function is not supported
>> then return an error.
>>
>> Fixes: 29b74236bd57 ("ASoC: tas2562: Introduce the TAS2562 amplifier")
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>   scripts/conmakehash        | Bin 0 -> 13120 bytes
>>   scripts/sortextable        | Bin 0 -> 18040 bytes
>>   sound/soc/codecs/tas2562.c |   3 ++-
>>   3 files changed, 2 insertions(+), 1 deletion(-)
>>   create mode 100755 scripts/conmakehash
>>   create mode 100755 scripts/sortextable
>>
>> diff --git a/scripts/conmakehash b/scripts/conmakehash
>> new file mode 100755
>> index 0000000000000000000000000000000000000000..17eec37019b8ae45f42f3c82046d1a55a6f69cb3
>> GIT binary patch
>> literal 13120
>> zcmeHOeQ;D&mcN}25CU`u1i`Q23C#=v(j@XB0Wx-n4!le?@~!SFHl6fK(rc$X+x=RD
> This is...  fun?  I'm guessing it's not intentional, it's certainly a
> litt

Ugh! Resending without the extra files.

Dan

> le difficult to review.  :)

      reply	other threads:[~2020-02-18 18:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 17:47 Dan Murphy
2020-02-18 18:48 ` Mark Brown
2020-02-18 18:52   ` Dan Murphy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89e205b4-ba03-8db6-ff75-acec3d954b52@ti.com \
    --to=dmurphy@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®