From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: icc-bwmon: Fix MSM8998 count unit
Date: Wed, 31 May 2023 19:05:06 +0200 [thread overview]
Message-ID: <89faee17-7858-194e-8af7-953a2631eb8d@linaro.org> (raw)
In-Reply-To: <693a36cf-e9d5-a6f1-3953-3a7c7567a754@linaro.org>
On 31.05.2023 19:03, Krzysztof Kozlowski wrote:
> On 31/05/2023 18:33, Konrad Dybcio wrote:
>> MSM8998's BWMON counts in megabytes. Fix it.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> drivers/soc/qcom/icc-bwmon.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> If this is
> https://lore.kernel.org/all/33c61f23-6442-6d9b-492f-dd6e9c64a8c1@quicinc.com/
> (and QLT 1872) then add reported-by tag.
It's not, I fired up 8998, added debug prints and ran mybw.
>
> Change seems logical, although not really documented (a bit
> contradictory information for sdm845), so assuming this was really tested:
It's not for sdm845, after the last cleanup both BWMONs on that
one got its own driver data struct.
Konrad
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-05-31 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 16:33 Konrad Dybcio
2023-05-31 17:03 ` Krzysztof Kozlowski
2023-05-31 17:05 ` Konrad Dybcio [this message]
2023-05-31 17:10 ` Krzysztof Kozlowski
2023-06-13 22:30 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89faee17-7858-194e-8af7-953a2631eb8d@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®