From: Mario Limonciello <superm1@kernel.org>
To: Zhan Xusheng <zhanxusheng1024@gmail.com>
Cc: Huang Rui <ray.huang@amd.com>, Perry Yuan <perry.yuan@amd.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Dhananjay Ugwekar <dhananjay.ugwekar@amd.com>,
"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhan Xusheng <zhanxusheng@xiaomi.com>
Subject: Re: [PATCH] cpufreq/amd-pstate: drop stale @epp_cached kdoc
Date: Tue, 26 May 2026 16:04:03 +0100 [thread overview]
Message-ID: <89fecc75-1eac-4caa-b8a4-805dda2dd940@kernel.org> (raw)
In-Reply-To: <20260526022131.1302373-1-zhanxusheng@xiaomi.com>
On 5/26/26 03:21, Zhan Xusheng wrote:
> Commit 4e16c1175238 ("cpufreq/amd-pstate: Stop caching EPP") removed
> the epp_cached field from struct amd_cpudata in favour of always
> reading from cppc_req_cached, but the kdoc above the struct still
> documents @epp_cached.
>
> Drop the now-stale @epp_cached entry.
>
> Fixes: 4e16c1175238 ("cpufreq/amd-pstate: Stop caching EPP")
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
> ---
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Also added to my tree.
> drivers/cpufreq/amd-pstate.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h
> index e4722e54387b..23e8baa05849 100644
> --- a/drivers/cpufreq/amd-pstate.h
> +++ b/drivers/cpufreq/amd-pstate.h
> @@ -84,7 +84,6 @@ struct amd_aperf_mperf {
> * @hw_prefcore: check whether HW supports preferred core featue.
> * Only when hw_prefcore and early prefcore param are true,
> * AMD P-State driver supports preferred core featue.
> - * @epp_cached: Cached CPPC energy-performance preference value
> * @policy: Cpufreq policy value
> * @suspended: If CPU core if offlined
> * @epp_default_ac: Default EPP value for AC power source
prev parent reply other threads:[~2026-05-26 15:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 2:21 Zhan Xusheng
2026-05-26 15:04 ` Mario Limonciello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89fecc75-1eac-4caa-b8a4-805dda2dd940@kernel.org \
--to=superm1@kernel.org \
--cc=dhananjay.ugwekar@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=perry.yuan@amd.com \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
--cc=zhanxusheng1024@gmail.com \
--cc=zhanxusheng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®