* [PATCH] cpufreq/amd-pstate: drop stale @epp_cached kdoc
@ 2026-05-26 2:21 Zhan Xusheng
2026-05-26 15:04 ` Mario Limonciello
0 siblings, 1 reply; 2+ messages in thread
From: Zhan Xusheng @ 2026-05-26 2:21 UTC (permalink / raw)
To: Mario Limonciello
Cc: Huang Rui, Perry Yuan, K Prateek Nayak, Rafael J. Wysocki,
Viresh Kumar, Dhananjay Ugwekar, Gautham R. Shenoy, linux-pm,
linux-kernel, Zhan Xusheng
Commit 4e16c1175238 ("cpufreq/amd-pstate: Stop caching EPP") removed
the epp_cached field from struct amd_cpudata in favour of always
reading from cppc_req_cached, but the kdoc above the struct still
documents @epp_cached.
Drop the now-stale @epp_cached entry.
Fixes: 4e16c1175238 ("cpufreq/amd-pstate: Stop caching EPP")
Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
---
drivers/cpufreq/amd-pstate.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h
index e4722e54387b..23e8baa05849 100644
--- a/drivers/cpufreq/amd-pstate.h
+++ b/drivers/cpufreq/amd-pstate.h
@@ -84,7 +84,6 @@ struct amd_aperf_mperf {
* @hw_prefcore: check whether HW supports preferred core featue.
* Only when hw_prefcore and early prefcore param are true,
* AMD P-State driver supports preferred core featue.
- * @epp_cached: Cached CPPC energy-performance preference value
* @policy: Cpufreq policy value
* @suspended: If CPU core if offlined
* @epp_default_ac: Default EPP value for AC power source
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] cpufreq/amd-pstate: drop stale @epp_cached kdoc
2026-05-26 2:21 [PATCH] cpufreq/amd-pstate: drop stale @epp_cached kdoc Zhan Xusheng
@ 2026-05-26 15:04 ` Mario Limonciello
0 siblings, 0 replies; 2+ messages in thread
From: Mario Limonciello @ 2026-05-26 15:04 UTC (permalink / raw)
To: Zhan Xusheng
Cc: Huang Rui, Perry Yuan, K Prateek Nayak, Rafael J. Wysocki,
Viresh Kumar, Dhananjay Ugwekar, Gautham R. Shenoy, linux-pm,
linux-kernel, Zhan Xusheng
On 5/26/26 03:21, Zhan Xusheng wrote:
> Commit 4e16c1175238 ("cpufreq/amd-pstate: Stop caching EPP") removed
> the epp_cached field from struct amd_cpudata in favour of always
> reading from cppc_req_cached, but the kdoc above the struct still
> documents @epp_cached.
>
> Drop the now-stale @epp_cached entry.
>
> Fixes: 4e16c1175238 ("cpufreq/amd-pstate: Stop caching EPP")
> Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
> ---
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Also added to my tree.
> drivers/cpufreq/amd-pstate.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.h b/drivers/cpufreq/amd-pstate.h
> index e4722e54387b..23e8baa05849 100644
> --- a/drivers/cpufreq/amd-pstate.h
> +++ b/drivers/cpufreq/amd-pstate.h
> @@ -84,7 +84,6 @@ struct amd_aperf_mperf {
> * @hw_prefcore: check whether HW supports preferred core featue.
> * Only when hw_prefcore and early prefcore param are true,
> * AMD P-State driver supports preferred core featue.
> - * @epp_cached: Cached CPPC energy-performance preference value
> * @policy: Cpufreq policy value
> * @suspended: If CPU core if offlined
> * @epp_default_ac: Default EPP value for AC power source
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-26 15:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-26 2:21 [PATCH] cpufreq/amd-pstate: drop stale @epp_cached kdoc Zhan Xusheng
2026-05-26 15:04 ` Mario Limonciello
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®