From: Kumar Gala <galak@codeaurora.org>
To: Tim Bird <tim.bird@sonymobile.com>
Cc: "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"\"Andersson, Björn\"" <Bjorn.Andersson@sonymobile.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"arnd.bergmann@linaro.org" <arnd.bergmann@linaro.org>
Subject: Re: [PATCH] ARM: dts: Add initial DTS file for Sony Xperia Z1 phone
Date: Tue, 16 Sep 2014 16:50:33 -0700 [thread overview]
Message-ID: <8F13381C-BBEF-4602-B5C4-A885B946BDBB@codeaurora.org> (raw)
In-Reply-To: <5418C471.9000807@sonymobile.com>
On Sep 16, 2014, at 4:14 PM, Tim Bird <tim.bird@sonymobile.com> wrote:
>
>
> On 09/16/2014 04:08 PM, Kumar Gala wrote:
>>
>> On Sep 16, 2014, at 4:03 PM, Tim Bird <tim.bird@sonymobile.com> wrote:
>>
>>> This DTS has initial support for just a serial console, for the
>>> Sony Xperia Z1 phone. This phone uses a QualComm 8074 processor.
>>>
>>
>> Qualcomm, the C isn’t caps.
>
> Will fix.
>>
>>> Signed-off-by: Tim Bird <tim.bird@sonymobile.com>
>>> ---
>>> arch/arm/boot/dts/Makefile | 1 +
>>> arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts | 18 ++++++++++++++++++
>>> 2 files changed, 19 insertions(+)
>>> create mode 100644 arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>> index b8c5cd3..680ce7e 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -341,6 +341,7 @@ dtb-$(CONFIG_ARCH_PRIMA2) += prima2-evb.dtb
>>> dtb-$(CONFIG_ARCH_QCOM) += \
>>> qcom-apq8064-ifc6410.dtb \
>>> qcom-apq8074-dragonboard.dtb \
>>> + qcom-apq8074-xperia-z1.dtb \
>>> qcom-apq8084-mtp.dtb \
>>> qcom-msm8660-surf.dtb \
>>> qcom-msm8960-cdp.dtb
>>> diff --git a/arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts b/arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts
>>> new file mode 100644
>>> index 0000000..59b3fa1
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/qcom-apq8074-xperia-z1.dts
>>> @@ -0,0 +1,18 @@
>>> +#include "qcom-msm8974.dtsi"
>>> +
>>> +/ {
>>> + model = "Sony Xperia Z1 phone";
>>> + compatible = "qcom,msm8974”;
>>
>> Should have a board compat as well
> I'll ask Bjorn what we want to do here. There was a compat that I stripped,
> but I'm not sure we settled on the official name we want. In any event,
> will fix.
>>
>>> + qcom,msm-id = <126 8 0>, <185 8 0>, <186 8 0>;
>>
>> We don’t have qcom,msm-id upstream at this time.
> Do I just leave this out, then?
yes, lets drop it for now, unless you guys need it to boot the upstream kernel on your hw.
>
> Thanks.
> -- Tim
>
> P.S. By now you probably noticed I mis-typed device-tree@vger.kernel.org. I'll fix that also.
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2014-09-16 23:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 23:03 Tim Bird
2014-09-16 23:08 ` Kumar Gala
2014-09-16 23:14 ` Tim Bird
2014-09-16 23:50 ` Kumar Gala [this message]
2014-09-18 17:51 ` Bjorn Andersson
2014-09-20 1:50 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8F13381C-BBEF-4602-B5C4-A885B946BDBB@codeaurora.org \
--to=galak@codeaurora.org \
--cc=Bjorn.Andersson@sonymobile.com \
--cc=arnd.bergmann@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.bird@sonymobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®