From: Bart Van Assche <bvanassche@acm.org>
To: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Finn Thain" <fthain@linux-m68k.org>,
"Michael Schmitz" <schmitzmic@gmail.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] scsi: Improve style of pnp_device_id array terminator
Date: Wed, 10 Jun 2026 09:19:08 -0700 [thread overview]
Message-ID: <8a07bac5-7083-4cf2-966a-2d5281e52a2a@acm.org> (raw)
In-Reply-To: <096aaa981c0bf1aaa8be75e675f17b1c9ca0086c.1781102092.git.u.kleine-koenig@baylibre.com>
On 6/10/26 7:36 AM, Uwe Kleine-König (The Capable Hub) wrote:
> diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
> index fd766282d4a4..93dab19c1cb9 100644
> --- a/drivers/scsi/aha1542.c
> +++ b/drivers/scsi/aha1542.c
> @@ -1083,7 +1083,7 @@ static int isa_registered;
> #ifdef CONFIG_PNP
> static const struct pnp_device_id aha1542_pnp_ids[] = {
> { .id = "ADP1542" },
> - { .id = "" }
> + { }
> };
> MODULE_DEVICE_TABLE(pnp, aha1542_pnp_ids);
>
> diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c
> index 270eae7ac427..41731a7304dd 100644
> --- a/drivers/scsi/g_NCR5380.c
> +++ b/drivers/scsi/g_NCR5380.c
> @@ -739,7 +739,7 @@ static struct isa_driver generic_NCR5380_isa_driver = {
> #ifdef CONFIG_PNP
> static const struct pnp_device_id generic_NCR5380_pnp_ids[] = {
> { .id = "DTC436e", .driver_data = BOARD_DTC3181E },
> - { .id = "" }
> + { }
> };
> MODULE_DEVICE_TABLE(pnp, generic_NCR5380_pnp_ids);
Although in general I'm not a fan of code cleanups for legacy drivers, I
like this change. Hence:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2026-06-10 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 14:36 Uwe Kleine-König (The Capable Hub)
2026-06-10 15:46 ` John Garry
2026-06-10 20:56 ` Uwe Kleine-König (The Capable Hub)
2026-06-10 16:19 ` Bart Van Assche [this message]
2026-07-12 19:25 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a07bac5-7083-4cf2-966a-2d5281e52a2a@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=fthain@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=schmitzmic@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome