Re: [PATCH v1] scsi: Improve style of pnp_device_id array terminator

[John Garry <john.g.garry@oracle.com>]

On 10/06/2026 15:36, Uwe Kleine-König (The Capable Hub) wrote:
> To match how device-id array terminators look like for other device
> types drop `.id = ""` from it and let the compiler care for zeroing the
> entry.
> 
> There are no changes in the compiled drivers, only the source looks
> nicer.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> Hello,
> 
> I'm currently working on changing various *_device_id definitions.
> This patch is irrelevant for this quest and a pure style update for
> consistency reasons without further dependencies on it. I just stumbled
> over this while working on that quest.
> 
> So if you don't like this patch, I won't insist.
> 
> Best regards
> Uwe
> 
>   drivers/scsi/aha1542.c   | 2 +-
>   drivers/scsi/g_NCR5380.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
> index fd766282d4a4..93dab19c1cb9 100644
> --- a/drivers/scsi/aha1542.c
> +++ b/drivers/scsi/aha1542.c
> @@ -1083,7 +1083,7 @@ static int isa_registered;
>   #ifdef CONFIG_PNP
>   static const struct pnp_device_id aha1542_pnp_ids[] = {
>   	{ .id = "ADP1542" },
> -	{ .id = "" }

It seems to be standard practice to use { .id = "" } as pnp dev table 
sentinel - so why change? Are they all going to be changed?

> +	{ }
>   };
>   MODULE_DEVICE_TABLE(pnp, aha1542_pnp_ids);
>   
> diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c
> index 270eae7ac427..41731a7304dd 100644
> --- a/drivers/scsi/g_NCR5380.c
> +++ b/drivers/scsi/g_NCR5380.c
> @@ -739,7 +739,7 @@ static struct isa_driver generic_NCR5380_isa_driver = {
>   #ifdef CONFIG_PNP
>   static const struct pnp_device_id generic_NCR5380_pnp_ids[] = {
>   	{ .id = "DTC436e", .driver_data = BOARD_DTC3181E },
> -	{ .id = "" }
> +	{ }
>   };
>   MODULE_DEVICE_TABLE(pnp, generic_NCR5380_pnp_ids);
>   
> 
> base-commit: 49e02880ec0a8c378e811bc9d85da188d7c6204c