Re: [PATCH 3/4] arm64: dts: qcom: kaanapali: Add CoreSight nodes for APSS debug block

[Jie Gan <jie.gan@oss.qualcomm.com>]

On 10/15/2026 5:06 PM, Konrad Dybcio wrote:
> On 10/15/26 4:26 AM, Jie Gan wrote:
>>
>>
>> On 10/14/2026 9:23 AM, Jie Gan wrote:
>>>
>>>
>>> On 10/13/2026 8:49 PM, Konrad Dybcio wrote:
>>>> On 9/22/26 12:35 PM, Jie Gan wrote:
>>>>> The APSS debug block is built with CoreSight devices like ETE,
>>>>> replicator, funnel and TMC ETF. Add dt nodes for these devices to enable
>>>>> ETM trace.
> 
> [...]
> 
>>>>> +        tmc@1d029000 {
>>>>> +            compatible = "arm,coresight-tmc", "arm,primecell";
>>>>> +            reg = <0x0 0x1d029000 0x0 0x1000>;
>>>>> +
>>>>> +            clocks = <&aoss_qmp>;
>>>>> +            clock-names = "apb_pclk";
>>>>> +            power-domains = <&cluster_pd>;
>>>>
>>>> Is there only being a single cluster_pd a mistake on kaanapali?
>>>>
>>>
>>>   From psci map, KNP only has one cluster_pd shared among all CPUs.
>>>
>>> Hi Jingyi,
>>>
>>> Can you please help to comment this part?
>>
>> Hi Konrad,
>>
>> We have cross checked the cluster info.
>>
>> The PD configuration for these two clusters is identical byte-for-byte and is based on cluster_cl5. I believe this is why they share the same cluster PD.
>>
>>                  domain-idle-states {
>>                          cluster_cl5: cluster-sleep-0 {
>>                                  compatible = "domain-idle-state";
>>                                  arm,psci-suspend-param = <0x01000054>;
>>                                  entry-latency-us = <2150>;
>>                                  exit-latency-us = <1983>;
>>                                  min-residency-us = <9144>;
>>                          };
> 
> Right, the configuration is the same, but ganging them up in a single
> power-domain prevents one of the clusters from going offline
> independently from Linux's PoV

That's making sense, we need fix it.

Thanks,
Jie

> 
> Konrad