From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mengqi Zhang <mengqi.zhang@mediatek.com>,
chaotian.jing@mediatek.com, ulf.hansson@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
matthias.bgg@gmail.com, wenbin.mei@mediatek.com
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bingdings: mmc: Mediatek: add ICE clock
Date: Tue, 18 Oct 2022 14:30:02 -0400 [thread overview]
Message-ID: <8a418360-400f-ff00-4230-865af883f17d@linaro.org> (raw)
In-Reply-To: <5d87f1c3-1c73-054b-dca1-9f52939e187d@linaro.org>
On 18/10/2022 14:29, Krzysztof Kozlowski wrote:
> On 17/10/2022 10:20, Mengqi Zhang wrote:
>> Document the binding for crypto clock of the Inline Crypto Engine
>> of Mediatek SoCs.
> > This does not match the patch contents at all.
Ah, my bad, I read "crypto block", not clock, so it matches. :)
However you are not documenting a binding for it. You are adding
optional clock.
>
>>
>> Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com>
>> ---
>> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>
> Best regards,
> Krzysztof
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-18 18:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 14:20 [PATCH 0/2] MediaTek eMMC inline encryption support Mengqi Zhang
2022-10-17 14:20 ` [PATCH 1/2] mmc: mtk-sd: add Inline Crypto Engine support Mengqi Zhang
2022-10-18 9:50 ` AngeloGioacchino Del Regno
2022-10-31 6:58 ` Mengqi Zhang (张梦琦)
2022-10-31 9:50 ` Mengqi Zhang (张梦琦)
2022-10-31 13:04 ` AngeloGioacchino Del Regno
2022-10-17 14:20 ` [PATCH 2/2] dt-bingdings: mmc: Mediatek: add ICE clock Mengqi Zhang
2022-10-18 9:50 ` AngeloGioacchino Del Regno
2022-11-06 9:53 ` Mengqi Zhang (张梦琦)
2022-10-18 18:29 ` Krzysztof Kozlowski
2022-10-18 18:30 ` Krzysztof Kozlowski [this message]
2022-11-02 15:13 ` Ulf Hansson
2022-11-06 10:10 ` Mengqi Zhang (张梦琦)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a418360-400f-ff00-4230-865af883f17d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chaotian.jing@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mengqi.zhang@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wenbin.mei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®