Re: [PATCH 1/2] mmc: mtk-sd: add Inline Crypto Engine support

["Mengqi Zhang (张梦琦)" <Mengqi.Zhang@mediatek.com>]

On Tue, 2022-10-18 at 11:50 +0200, AngeloGioacchino Del Regno wrote:
> Il 17/10/22 16:20, Mengqi Zhang ha scritto:
> > add crypto clock control and ungate it before CQHCI init.
> > 
> > Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com>
> 
> Hello Mengqi,
> I'm a bit surprised that enabling ICE only requires enabling a clock
> as
> on downstream code I see some SMC calls to
> MTK_SIP_KERNEL_HW_FDE_MSDC_CTL.
> 
> Can you please explain why SMC calls are not needed here?
> 
> Thanks,
> Angelo

> Hi Angelo,
> 
> In some MTK SoCs, we need set a encrypto enable bit
> MTK_SIP_KERNEL_HW_FDE_MSDC_CTL in secure world, so we use SMC call to
> finish it.
> But not every MTK SoC need to set this bit in secure world. This
> patch is for these SoCs.
> As for SMC call, we haven't found a proper way to deal with it, we'll
> do it later.
> 
> Thanks,
> Mengqi.Zhang
>