From: Marek Szyprowski <m.szyprowski@samsung.com>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
boris.brezillon@collabora.com
Cc: robh@kernel.org, steven.price@arm.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, krzysztof.kozlowski@linaro.org
Subject: Re: [PATCH v2 0/3] drm/panfrost: Fix poweroff and sync IRQs for suspend
Date: Wed, 29 Nov 2023 18:31:21 +0100 [thread overview]
Message-ID: <8a4b80dc-0841-48f8-81ad-7486bc57f3d7@samsung.com> (raw)
In-Reply-To: <20231128124510.391007-1-angelogioacchino.delregno@collabora.com>
On 28.11.2023 13:45, AngeloGioacchino Del Regno wrote:
> This series contains a fast fix for the basic GPU poweroff functionality
> and goes further by implementing interrupt masking and synchronization
> before suspend.
>
> For more information, please look at the conversation at [1], which
> explains the regression seen with the poweroff commit and the initial
> approaches taken to solve that.
Just to let You know, as there is still some discussion about
beautifying the final code, I've tested this version on my test hardware
and everything works fine again! Thanks!
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Cheers!
>
> [1]: https://lore.kernel.org/all/20231123095320.41433-1-angelogioacchino.delregno@collabora.com/
>
> AngeloGioacchino Del Regno (3):
> drm/panfrost: Ignore core_mask for poweroff and disable PWRTRANS irq
> drm/panfrost: Add gpu_irq, mmu_irq to struct panfrost_device
> drm/panfrost: Synchronize and disable interrupts before powering off
>
> drivers/gpu/drm/panfrost/panfrost_device.c | 4 +++
> drivers/gpu/drm/panfrost/panfrost_device.h | 9 +++++++
> drivers/gpu/drm/panfrost/panfrost_gpu.c | 29 +++++++++++++++-------
> drivers/gpu/drm/panfrost/panfrost_gpu.h | 1 +
> drivers/gpu/drm/panfrost/panfrost_job.c | 18 +++++++++++---
> drivers/gpu/drm/panfrost/panfrost_job.h | 1 +
> drivers/gpu/drm/panfrost/panfrost_mmu.c | 27 ++++++++++++++------
> drivers/gpu/drm/panfrost/panfrost_mmu.h | 1 +
> 8 files changed, 70 insertions(+), 20 deletions(-)
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
prev parent reply other threads:[~2023-11-29 17:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20231128124521eucas1p203694ed4721b9ffcde6f7f1d1933d56a@eucas1p2.samsung.com>
2023-11-28 12:45 ` AngeloGioacchino Del Regno
2023-11-28 12:45 ` [PATCH v2 1/3] drm/panfrost: Ignore core_mask for poweroff and disable PWRTRANS irq AngeloGioacchino Del Regno
2023-11-28 13:27 ` Boris Brezillon
2023-11-28 12:45 ` [PATCH v2 2/3] drm/panfrost: Add gpu_irq, mmu_irq to struct panfrost_device AngeloGioacchino Del Regno
2023-11-28 13:31 ` Boris Brezillon
2023-11-28 12:45 ` [PATCH v2 3/3] drm/panfrost: Synchronize and disable interrupts before powering off AngeloGioacchino Del Regno
2023-11-28 13:57 ` Boris Brezillon
2023-11-28 15:10 ` AngeloGioacchino Del Regno
2023-11-28 15:53 ` Boris Brezillon
2023-11-28 16:10 ` AngeloGioacchino Del Regno
2023-11-28 16:41 ` Boris Brezillon
2023-11-28 14:06 ` Boris Brezillon
2023-11-28 15:10 ` AngeloGioacchino Del Regno
2023-11-28 15:38 ` Boris Brezillon
2023-11-28 15:42 ` AngeloGioacchino Del Regno
2023-11-28 15:58 ` Boris Brezillon
2023-11-29 17:31 ` Marek Szyprowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a4b80dc-0841-48f8-81ad-7486bc57f3d7@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®