mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] clk: qcom: negcc-nord: Add the secondary QUSB2 PHY reset
@ 2026-09-01  3:53 Shawn Guo
  2026-09-01  3:53 ` [PATCH 1/2] dt-bindings: clock: qcom: nord-negcc: " Shawn Guo
  2026-09-01  3:53 ` [PATCH 2/2] clk: qcom: negcc-nord: " Shawn Guo
  0 siblings, 2 replies; 5+ messages in thread
From: Shawn Guo @ 2026-09-01  3:53 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Stephen Boyd, Brian Masney, Jerome Brunet, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
	Krishna Kurapati, linux-arm-msm, linux-clk, linux-kernel,
	Shawn Guo

The series adds the missing secondary QUSB2 PHY reset to negcc-nord
clock driver, so that usb_1_hsphy can be enabled properly on Nord
platform.

Bartosz Golaszewski (2):
  dt-bindings: clock: qcom: nord-negcc: Add the secondary QUSB2 PHY
    reset
  clk: qcom: negcc-nord: Add the secondary QUSB2 PHY reset

 drivers/clk/qcom/negcc-nord.c               | 1 +
 include/dt-bindings/clock/qcom,nord-negcc.h | 1 +
 2 files changed, 2 insertions(+)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] dt-bindings: clock: qcom: nord-negcc: Add the secondary QUSB2 PHY reset
  2026-09-01  3:53 [PATCH 0/2] clk: qcom: negcc-nord: Add the secondary QUSB2 PHY reset Shawn Guo
@ 2026-09-01  3:53 ` Shawn Guo
  2026-09-01  5:42   ` Taniya Das
  2026-09-01  3:53 ` [PATCH 2/2] clk: qcom: negcc-nord: " Shawn Guo
  1 sibling, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2026-09-01  3:53 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Stephen Boyd, Brian Masney, Jerome Brunet, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
	Krishna Kurapati, linux-arm-msm, linux-clk, linux-kernel,
	Bartosz Golaszewski, Shawn Guo

From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

The NE_GCC block has two eUSB2 PHY block resets - PRIM and SEC - but
right now only the primary is registered. Add the secondary, which is
required by the usb_1 eUSB2 PHY.

Note that the SoC has three eUSB2 PHYs but only these two QUSB2PHY
resets: the HS-only USB20 tile has no dedicated QUSB2PHY reset and
is instead reset as a whole via NE_GCC_USB20_PRIM_BCR.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
 include/dt-bindings/clock/qcom,nord-negcc.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/clock/qcom,nord-negcc.h b/include/dt-bindings/clock/qcom,nord-negcc.h
index a7024317e90b..ad9ff389956d 100644
--- a/include/dt-bindings/clock/qcom,nord-negcc.h
+++ b/include/dt-bindings/clock/qcom,nord-negcc.h
@@ -121,5 +121,6 @@
 #define NE_GCC_USB3PHY_PHY_PRIM_BCR				11
 #define NE_GCC_USB3PHY_PHY_SEC_BCR				12
 #define NE_GCC_QUSB2PHY_PRIM_BCR				13
+#define NE_GCC_QUSB2PHY_SEC_BCR					14
 
 #endif
-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] clk: qcom: negcc-nord: Add the secondary QUSB2 PHY reset
  2026-09-01  3:53 [PATCH 0/2] clk: qcom: negcc-nord: Add the secondary QUSB2 PHY reset Shawn Guo
  2026-09-01  3:53 ` [PATCH 1/2] dt-bindings: clock: qcom: nord-negcc: " Shawn Guo
@ 2026-09-01  3:53 ` Shawn Guo
  2026-09-01  5:43   ` Taniya Das
  1 sibling, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2026-09-01  3:53 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Stephen Boyd, Brian Masney, Jerome Brunet, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
	Krishna Kurapati, linux-arm-msm, linux-clk, linux-kernel,
	Bartosz Golaszewski, Shawn Guo

From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Add the secondary USB2 PHY reset which is needed by usb_1_hsphy
enabling on Nord platform.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
 drivers/clk/qcom/negcc-nord.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/negcc-nord.c b/drivers/clk/qcom/negcc-nord.c
index 0db284edc4e4..896050291af0 100644
--- a/drivers/clk/qcom/negcc-nord.c
+++ b/drivers/clk/qcom/negcc-nord.c
@@ -1877,6 +1877,7 @@ static const struct qcom_reset_map ne_gcc_nord_resets[] = {
 	[NE_GCC_USB3PHY_PHY_PRIM_BCR] = { 0x2b004 },
 	[NE_GCC_USB3PHY_PHY_SEC_BCR] = { 0x2d004 },
 	[NE_GCC_QUSB2PHY_PRIM_BCR] = { 0x2e000 },
+	[NE_GCC_QUSB2PHY_SEC_BCR] = { 0x2f000 },
 };
 
 static const struct clk_rcg_dfs_data ne_gcc_nord_dfs_clocks[] = {
-- 
2.43.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dt-bindings: clock: qcom: nord-negcc: Add the secondary QUSB2 PHY reset
  2026-09-01  3:53 ` [PATCH 1/2] dt-bindings: clock: qcom: nord-negcc: " Shawn Guo
@ 2026-09-01  5:42   ` Taniya Das
  0 siblings, 0 replies; 5+ messages in thread
From: Taniya Das @ 2026-09-01  5:42 UTC (permalink / raw)
  To: Shawn Guo, Bjorn Andersson
  Cc: Stephen Boyd, Brian Masney, Jerome Brunet, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
	Krishna Kurapati, linux-arm-msm, linux-clk, linux-kernel,
	Bartosz Golaszewski



On 9/1/2026 9:23 AM, Shawn Guo wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> 
> The NE_GCC block has two eUSB2 PHY block resets - PRIM and SEC - but
> right now only the primary is registered. Add the secondary, which is
> required by the usb_1 eUSB2 PHY.
> 
> Note that the SoC has three eUSB2 PHYs but only these two QUSB2PHY
> resets: the HS-only USB20 tile has no dedicated QUSB2PHY reset and
> is instead reset as a whole via NE_GCC_USB20_PRIM_BCR.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>


Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>

-- 
Thanks,
Taniya Das


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] clk: qcom: negcc-nord: Add the secondary QUSB2 PHY reset
  2026-09-01  3:53 ` [PATCH 2/2] clk: qcom: negcc-nord: " Shawn Guo
@ 2026-09-01  5:43   ` Taniya Das
  0 siblings, 0 replies; 5+ messages in thread
From: Taniya Das @ 2026-09-01  5:43 UTC (permalink / raw)
  To: Shawn Guo, Bjorn Andersson
  Cc: Stephen Boyd, Brian Masney, Jerome Brunet, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Bartosz Golaszewski,
	Krishna Kurapati, linux-arm-msm, linux-clk, linux-kernel,
	Bartosz Golaszewski



On 9/1/2026 9:23 AM, Shawn Guo wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> 
> Add the secondary USB2 PHY reset which is needed by usb_1_hsphy
> enabling on Nord platform.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> ---
>  drivers/clk/qcom/negcc-nord.c | 1 +
>  1 file changed, 1 insertion(+)


Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com>

-- 
Thanks,
Taniya Das


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-09-01  5:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-01  3:53 [PATCH 0/2] clk: qcom: negcc-nord: Add the secondary QUSB2 PHY reset Shawn Guo
2026-09-01  3:53 ` [PATCH 1/2] dt-bindings: clock: qcom: nord-negcc: " Shawn Guo
2026-09-01  5:42   ` Taniya Das
2026-09-01  3:53 ` [PATCH 2/2] clk: qcom: negcc-nord: " Shawn Guo
2026-09-01  5:43   ` Taniya Das

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®