* [PATCH] drm/imagination: Fix ROGUE_MAX_COMPUTE_SHARED_REGISTERS
@ 2026-02-06 9:59 Matt Coster
2026-02-10 10:33 ` Frank Binns
0 siblings, 1 reply; 2+ messages in thread
From: Matt Coster @ 2026-02-06 9:59 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Simona Vetter
Cc: Simon Perretta, Frank Binns, Brajesh Gupta, Alessio Belle,
Alexandru Dadu, dri-devel, linux-kernel, stable, Matt Coster
Remove a spurious 2x multiplier from this def which can cause instability
in larger compute workloads on hardware with enhancement 38020 present.
Fixes: b41ae495207e ("drm/imagination: Add GPU register headers")
Cc: stable@vger.kernel.org
Suggested-by: Simon Perretta <simon.perretta@imgtec.com>
Signed-off-by: Matt Coster <matt.coster@imgtec.com>
---
drivers/gpu/drm/imagination/pvr_rogue_defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imagination/pvr_rogue_defs.h b/drivers/gpu/drm/imagination/pvr_rogue_defs.h
index 932b01686008..1fde3be43afe 100644
--- a/drivers/gpu/drm/imagination/pvr_rogue_defs.h
+++ b/drivers/gpu/drm/imagination/pvr_rogue_defs.h
@@ -114,7 +114,7 @@
ROGUE_CR_FWCORE_ADDR_REMAP_CONFIG0_CBASE_CLRMSK
#define FWCORE_ADDR_REMAP_CONFIG0_SIZE_ALIGNSHIFT (12U)
-#define ROGUE_MAX_COMPUTE_SHARED_REGISTERS (2 * 1024)
+#define ROGUE_MAX_COMPUTE_SHARED_REGISTERS 1024
#define ROGUE_MAX_VERTEX_SHARED_REGISTERS 1024
#define ROGUE_MAX_PIXEL_SHARED_REGISTERS 1024
#define ROGUE_CSRM_LINE_SIZE_IN_DWORDS (64 * 4 * 4)
---
base-commit: 5023ca80f9589295cb60735016e39fc5cc714243
change-id: 20260130-rogue-max-compute-shared-registers-fffe1e714773
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/imagination: Fix ROGUE_MAX_COMPUTE_SHARED_REGISTERS
2026-02-06 9:59 [PATCH] drm/imagination: Fix ROGUE_MAX_COMPUTE_SHARED_REGISTERS Matt Coster
@ 2026-02-10 10:33 ` Frank Binns
0 siblings, 0 replies; 2+ messages in thread
From: Frank Binns @ 2026-02-10 10:33 UTC (permalink / raw)
To: Matt Coster, maarten.lankhorst, mripard, airlied, tzimmermann, simona
Cc: dri-devel, stable, Brajesh Gupta, Alexandru Dadu, Simon Perretta,
Alessio Belle, linux-kernel
On Fri, 2026-02-06 at 09:59 +0000, Matt Coster wrote:
> Remove a spurious 2x multiplier from this def which can cause instability
> in larger compute workloads on hardware with enhancement 38020 present.
>
> Fixes: b41ae495207e ("drm/imagination: Add GPU register headers")
> Cc: stable@vger.kernel.org
> Suggested-by: Simon Perretta <simon.perretta@imgtec.com>
> Signed-off-by: Matt Coster <matt.coster@imgtec.com>
Reviewed-by: Frank Binns <frank.binns@imgtec.com>
> ---
> drivers/gpu/drm/imagination/pvr_rogue_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/imagination/pvr_rogue_defs.h b/drivers/gpu/drm/imagination/pvr_rogue_defs.h
> index 932b01686008..1fde3be43afe 100644
> --- a/drivers/gpu/drm/imagination/pvr_rogue_defs.h
> +++ b/drivers/gpu/drm/imagination/pvr_rogue_defs.h
> @@ -114,7 +114,7 @@
> ROGUE_CR_FWCORE_ADDR_REMAP_CONFIG0_CBASE_CLRMSK
> #define FWCORE_ADDR_REMAP_CONFIG0_SIZE_ALIGNSHIFT (12U)
>
> -#define ROGUE_MAX_COMPUTE_SHARED_REGISTERS (2 * 1024)
> +#define ROGUE_MAX_COMPUTE_SHARED_REGISTERS 1024
> #define ROGUE_MAX_VERTEX_SHARED_REGISTERS 1024
> #define ROGUE_MAX_PIXEL_SHARED_REGISTERS 1024
> #define ROGUE_CSRM_LINE_SIZE_IN_DWORDS (64 * 4 * 4)
>
> ---
> base-commit: 5023ca80f9589295cb60735016e39fc5cc714243
> change-id: 20260130-rogue-max-compute-shared-registers-fffe1e714773
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-10 10:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-06 9:59 [PATCH] drm/imagination: Fix ROGUE_MAX_COMPUTE_SHARED_REGISTERS Matt Coster
2026-02-10 10:33 ` Frank Binns
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®