mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Reconfigure 1.4GHz in AM62 PHYCORE SoM
@ 2024-10-01  7:19 Garrett Giordano
  2024-10-01  7:19 ` [PATCH v2 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz Garrett Giordano
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Garrett Giordano @ 2024-10-01  7:19 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, w.egorov
  Cc: linux-arm-kernel, devicetree, linux-kernel, upstream

This patch set moves our 1.4GHz opp table definition out of our overlay
and into our som dtsi. This change goes along with our updated PMIC, which
is now configured to output 0.85v by default.

We drop the overlay as it is no longer needed.

Changes in v2:
  - Use git revert to revert the overlay patch
  - Update commit message to reflect revert adding the device tree overlay

Garrett Giordano (2):
  arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz
  Revert "arm64: dts: ti: am62-phyboard-lyra: Add overlay to increase
    cpu frequency to 1.4 GHz"

 arch/arm64/boot/dts/ti/Makefile               |  3 ---
 .../boot/dts/ti/k3-am62-phycore-som.dtsi      | 11 ++++++++--
 .../k3-am625-phyboard-lyra-1-4-ghz-opp.dtso   | 20 -------------------
 3 files changed, 9 insertions(+), 25 deletions(-)
 delete mode 100644 arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso

--
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz
  2024-10-01  7:19 [PATCH v2 0/2] Reconfigure 1.4GHz in AM62 PHYCORE SoM Garrett Giordano
@ 2024-10-01  7:19 ` Garrett Giordano
  2024-10-02  6:09   ` Wadim Egorov
  2024-10-01  7:19 ` [PATCH v2 2/2] Revert "arm64: dts: ti: am62-phyboard-lyra: Add overlay to increase cpu frequency to 1.4 GHz" Garrett Giordano
  2024-10-28 15:05 ` [PATCH v2 0/2] Reconfigure 1.4GHz in AM62 PHYCORE SoM Vignesh Raghavendra
  2 siblings, 1 reply; 5+ messages in thread
From: Garrett Giordano @ 2024-10-01  7:19 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, w.egorov
  Cc: linux-arm-kernel, devicetree, linux-kernel, upstream

The am625 is capable of running at 1.4 GHz when VDD_CORE is increased
from 0.75V to 0.85V. Here we add a 1.4 GHz node to the a53_opp_table and
increase the VDD_CORE voltage accordingly.

Signed-off-by: Garrett Giordano <ggiordano@phytec.com>
---
 arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
index 43488cc8bcb1..236b94c0248c 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
@@ -173,6 +173,13 @@ AM62X_IOPAD(0x01f4, PIN_INPUT, 0) /* (D16) EXTINTn */
 	};
 };
 
+&a53_opp_table {
+	opp-1400000000 {
+		opp-hz = /bits/ 64 <1400000000>;
+		opp-supported-hw = <0x01 0x0004>;
+	};
+};
+
 &cpsw3g {
 	pinctrl-names = "default";
 	pinctrl-0 = <&main_rgmii1_pins_default>;
@@ -226,8 +233,8 @@ pmic@30 {
 		regulators {
 			vdd_core: buck1 {
 				regulator-name = "VDD_CORE";
-				regulator-min-microvolt = <750000>;
-				regulator-max-microvolt = <750000>;
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <850000>;
 				regulator-boot-on;
 				regulator-always-on;
 			};
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] Revert "arm64: dts: ti: am62-phyboard-lyra: Add overlay to increase cpu frequency to 1.4 GHz"
  2024-10-01  7:19 [PATCH v2 0/2] Reconfigure 1.4GHz in AM62 PHYCORE SoM Garrett Giordano
  2024-10-01  7:19 ` [PATCH v2 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz Garrett Giordano
@ 2024-10-01  7:19 ` Garrett Giordano
  2024-10-28 15:05 ` [PATCH v2 0/2] Reconfigure 1.4GHz in AM62 PHYCORE SoM Vignesh Raghavendra
  2 siblings, 0 replies; 5+ messages in thread
From: Garrett Giordano @ 2024-10-01  7:19 UTC (permalink / raw)
  To: nm, vigneshr, kristo, robh, krzk+dt, w.egorov
  Cc: linux-arm-kernel, devicetree, linux-kernel, upstream

We now configure the a53_opp_table to include a 1.4 GHz node and set our
VDD_CORE to 0.85v in the k3-am62-phycore-som.dtsi. This change is to
match our PMIC which is now set to output 0.85v by default.

This reverts commit 7a5775a3da906dab059b8de60a2b88f6016cb4b8.

Signed-off-by: Garrett Giordano <ggiordano@phytec.com>
---
Changes in v2:
  - Use git revert to revert the change

 arch/arm64/boot/dts/ti/Makefile               |  3 ---
 .../k3-am625-phyboard-lyra-1-4-ghz-opp.dtso   | 20 -------------------
 2 files changed, 23 deletions(-)
 delete mode 100644 arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso

diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
index e20b27ddf901..44052354503a 100644
--- a/arch/arm64/boot/dts/ti/Makefile
+++ b/arch/arm64/boot/dts/ti/Makefile
@@ -22,7 +22,6 @@ dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-dahlia.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-dev.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-mallow.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-am625-verdin-wifi-yavia.dtb
-dtb-$(CONFIG_ARCH_K3) += k3-am625-phyboard-lyra-1-4-ghz-opp.dtbo
 dtb-$(CONFIG_ARCH_K3) += k3-am62x-phyboard-lyra-gpio-fan.dtbo
 dtb-$(CONFIG_ARCH_K3) += k3-am62-lp-sk.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-am62-lp-sk-nand.dtbo
@@ -124,8 +123,6 @@ k3-am625-beagleplay-csi2-ov5640-dtbs := k3-am625-beagleplay.dtb \
 	k3-am625-beagleplay-csi2-ov5640.dtbo
 k3-am625-beagleplay-csi2-tevi-ov5640-dtbs := k3-am625-beagleplay.dtb \
 	k3-am625-beagleplay-csi2-tevi-ov5640.dtbo
-k3-am625-phyboard-lyra-1-4-ghz-opp.dtbs := k3-am625-phyboard-lyra-rdk.dtb \
-	k3-am625-phyboard-lyra-1-4-ghz-opp.dtbo
 k3-am625-phyboard-lyra-disable-eth-phy-dtbs := k3-am625-phyboard-lyra-rdk.dtb \
 	k3-am6xx-phycore-disable-eth-phy.dtbo
 k3-am625-phyboard-lyra-disable-rtc-dtbs := k3-am625-phyboard-lyra-rdk.dtb \
diff --git a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso b/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso
deleted file mode 100644
index 6ec6d57ec49c..000000000000
--- a/arch/arm64/boot/dts/ti/k3-am625-phyboard-lyra-1-4-ghz-opp.dtso
+++ /dev/null
@@ -1,20 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only OR MIT
-/*
- * Copyright (C) 2024 PHYTEC America LLC
- * Author: Nathan Morrisson <nmorrisson@phytec.com>
- */
-
-/dts-v1/;
-/plugin/;
-
-&vdd_core {
-	regulator-min-microvolt = <850000>;
-	regulator-max-microvolt = <850000>;
-};
-
-&a53_opp_table {
-	opp-1400000000 {
-		opp-hz = /bits/ 64 <1400000000>;
-		opp-supported-hw = <0x01 0x0004>;
-	};
-};
--
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz
  2024-10-01  7:19 ` [PATCH v2 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz Garrett Giordano
@ 2024-10-02  6:09   ` Wadim Egorov
  0 siblings, 0 replies; 5+ messages in thread
From: Wadim Egorov @ 2024-10-02  6:09 UTC (permalink / raw)
  To: Garrett Giordano, nm, vigneshr, kristo, robh, krzk+dt
  Cc: linux-arm-kernel, devicetree, linux-kernel, upstream



Am 01.10.24 um 09:19 schrieb Garrett Giordano:
> The am625 is capable of running at 1.4 GHz when VDD_CORE is increased
> from 0.75V to 0.85V. Here we add a 1.4 GHz node to the a53_opp_table and
> increase the VDD_CORE voltage accordingly.
> 
> Signed-off-by: Garrett Giordano <ggiordano@phytec.com>

Reviewed-by: Wadim Egorov <w.egorov@phytec.de>

> ---
>   arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
> index 43488cc8bcb1..236b94c0248c 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-phycore-som.dtsi
> @@ -173,6 +173,13 @@ AM62X_IOPAD(0x01f4, PIN_INPUT, 0) /* (D16) EXTINTn */
>   	};
>   };
>   
> +&a53_opp_table {
> +	opp-1400000000 {
> +		opp-hz = /bits/ 64 <1400000000>;
> +		opp-supported-hw = <0x01 0x0004>;
> +	};
> +};
> +
>   &cpsw3g {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&main_rgmii1_pins_default>;
> @@ -226,8 +233,8 @@ pmic@30 {
>   		regulators {
>   			vdd_core: buck1 {
>   				regulator-name = "VDD_CORE";
> -				regulator-min-microvolt = <750000>;
> -				regulator-max-microvolt = <750000>;
> +				regulator-min-microvolt = <850000>;
> +				regulator-max-microvolt = <850000>;
>   				regulator-boot-on;
>   				regulator-always-on;
>   			};


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 0/2] Reconfigure 1.4GHz in AM62 PHYCORE SoM
  2024-10-01  7:19 [PATCH v2 0/2] Reconfigure 1.4GHz in AM62 PHYCORE SoM Garrett Giordano
  2024-10-01  7:19 ` [PATCH v2 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz Garrett Giordano
  2024-10-01  7:19 ` [PATCH v2 2/2] Revert "arm64: dts: ti: am62-phyboard-lyra: Add overlay to increase cpu frequency to 1.4 GHz" Garrett Giordano
@ 2024-10-28 15:05 ` Vignesh Raghavendra
  2 siblings, 0 replies; 5+ messages in thread
From: Vignesh Raghavendra @ 2024-10-28 15:05 UTC (permalink / raw)
  To: nm, kristo, robh, krzk+dt, w.egorov, Garrett Giordano
  Cc: Vignesh Raghavendra, linux-arm-kernel, devicetree, linux-kernel,
	upstream

Hi Garrett Giordano,

On Tue, 01 Oct 2024 00:19:14 -0700, Garrett Giordano wrote:
> This patch set moves our 1.4GHz opp table definition out of our overlay
> and into our som dtsi. This change goes along with our updated PMIC, which
> is now configured to output 0.85v by default.
> 
> We drop the overlay as it is no longer needed.
> 
> Changes in v2:
>   - Use git revert to revert the overlay patch
>   - Update commit message to reflect revert adding the device tree overlay
> 
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz
      commit: bc3552d675537be111148d9614f4f02f31e30de3
[2/2] Revert "arm64: dts: ti: am62-phyboard-lyra: Add overlay to increase cpu frequency to 1.4 GHz"
      commit: 151ed40a4f204e8786a2573e3f8083ffd29f3b1e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-10-28 15:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-01  7:19 [PATCH v2 0/2] Reconfigure 1.4GHz in AM62 PHYCORE SoM Garrett Giordano
2024-10-01  7:19 ` [PATCH v2 1/2] arm64: dts: ti: am62-phycore-som: Increase cpu frequency to 1.4 GHz Garrett Giordano
2024-10-02  6:09   ` Wadim Egorov
2024-10-01  7:19 ` [PATCH v2 2/2] Revert "arm64: dts: ti: am62-phyboard-lyra: Add overlay to increase cpu frequency to 1.4 GHz" Garrett Giordano
2024-10-28 15:05 ` [PATCH v2 0/2] Reconfigure 1.4GHz in AM62 PHYCORE SoM Vignesh Raghavendra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®