From: Lin Wang <wanglin@open-hieco.net>
To: Borislav Petkov <bp@alien8.de>
Cc: yazen.ghannam@amd.com, mario.limonciello@amd.com,
tglx@kernel.org, mingo@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 5/5] x86/amd_node: Support Hygon SMN roots by socket
Date: Fri, 3 Apr 2026 13:29:36 +0800 [thread overview]
Message-ID: <8a90508f-04ef-4f6d-9f32-9b60e4a3aac8@open-hieco.net> (raw)
In-Reply-To: <20260402235036.GDac8AzDPVVq-tBeG-@fat_crate.local>
Hi Boris,
On 4/3/2026 7:50 AM, Borislav Petkov wrote:
>
> All Hygon enablement goes into Hygon-specific files. If there's a piece of
> functionality which is generic enough, then that can be extracted into
> a function which can be called by both vendors code.
>
> But pls forget this piggy-backing on AMD code and thus turning AMD code into
> an unmaintainable mess.
>
> Thx.
>
Thank you for the clear direction -- this is exactly the kind of
architectural guidance we needed at this stage.
Keeping Hygon enablement out of AMD code paths is the right call. We
will rethink the integration approach for v2 with that principle in mind.
Thx & br,
Lin
prev parent reply other threads:[~2026-04-03 5:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 11:15 [RFC PATCH 00/05] x86/hygon: Add Family 0x18 node enumeration and SMN access Lin Wang
2026-04-02 11:15 ` [RFC PATCH 1/5] pci_ids: Add Hygon Family 0x18 DF device IDs Lin Wang
2026-04-02 17:56 ` Mario Limonciello
2026-04-03 3:39 ` Lin Wang
2026-04-02 11:15 ` [RFC PATCH 2/5] x86/hygon: Add Family 0x18 node enumeration API header Lin Wang
2026-04-02 11:15 ` [RFC PATCH 3/5] x86/hygon: Add DF misc-based node enumeration helpers Lin Wang
2026-04-02 18:50 ` Mario Limonciello
2026-04-03 5:15 ` Lin Wang
2026-04-02 11:15 ` [RFC PATCH 4/5] x86/amd_nb: Use Hygon DF misc enumeration for Family 0x18 Lin Wang
2026-04-02 11:15 ` [RFC PATCH 5/5] x86/amd_node: Support Hygon SMN roots by socket Lin Wang
2026-04-02 23:50 ` Borislav Petkov
2026-04-03 5:29 ` Lin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a90508f-04ef-4f6d-9f32-9b60e4a3aac8@open-hieco.net \
--to=wanglin@open-hieco.net \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®