From: Shuah Khan <skhan@linuxfoundation.org>
To: Huang Rui <ray.huang@amd.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
linux-pm@vger.kernel.org
Cc: Deepak Sharma <deepak.sharma@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Steven Noonan <steven@valvesoftware.com>,
Nathan Fontenot <nathan.fontenot@amd.com>,
Jinzhou Su <Jinzhou.Su@amd.com>,
Xiaojian Du <Xiaojian.Du@amd.com>,
Perry Yuan <Perry.Yuan@amd.com>, Jassmine Meng <li.meng@amd.com>,
Borislav Petkov <bp@alien8.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Steven Rostedt <rostedt@goodmis.org>,
Giovanni Gherdovich <ggherdovich@suse.cz>,
linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH RESEND v6 0/9] cpupower: Add AMD P-State Support
Date: Fri, 18 Feb 2022 17:27:41 -0700 [thread overview]
Message-ID: <8aafb93a-772c-1806-e087-cd285694aa74@linuxfoundation.org> (raw)
In-Reply-To: <20220216073558.751071-1-ray.huang@amd.com>
On 2/16/22 12:35 AM, Huang Rui wrote:
> Hi Shuah,
>
> Since AMD P-State kernel is merged into 5.17-rc1, I would like to continue
> revising the AMD P-State support for the CPUPower tool. These series are
> rebased on latest bleeding-edge, any comments are warm for me.
>
> See patch series of CPUPower in below git repo:
> V1: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v1
> V2: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v2
> V3: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v3
> V4: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v4
> V5: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=amd-pstate-dev-v5
> V6: https://git.kernel.org/pub/scm/linux/kernel/git/rui/linux.git/log/?h=cpupower-amd-pstate
>
A few checkpatch warns to fix. I usually ignore CHECK from checkpatch,
but a few of them found on this series could improve the code.
Also is there a need to add/update manpages and documentation.
I tested these my AMD Ryzen 7 4700G system. I didn't play with set commands
and just the info ones.
cpupower info gave me this output. The first message is fine, but the
second one is a bit odd. Should it just bail out right after the first
message about "not support"
cpupower info
System does not support Intel's performance bias setting
analyzing CPU 0:
Go ahead send me v7 for these and add any mapages/doc if necessary.
I will get them into Linux 5.18-rc1
thanks,
-- Shuah
next prev parent reply other threads:[~2022-02-19 0:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 7:35 Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 1/9] cpupower: Add AMD P-State capability flag Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 2/9] cpupower: Add the function to check AMD P-State enabled Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 3/9] cpupower: Initial AMD P-State capability Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 4/9] cpupower: Add the function to get the sysfs value from specific table Huang Rui
2022-02-18 23:46 ` Shuah Khan
2022-02-20 14:22 ` Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 5/9] cpupower: Introduce ACPI CPPC library Huang Rui
2022-02-18 23:53 ` Shuah Khan
2022-02-20 14:34 ` Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 6/9] cpupower: Add AMD P-State sysfs definition and access helper Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 7/9] cpupower: Enable boost state support for AMD P-State module Huang Rui
2022-02-19 0:01 ` Shuah Khan
2022-02-20 14:35 ` Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 8/9] cpupower: Move print_speed function into misc helper Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 9/9] cpupower: Print AMD P-State information on cpupower Huang Rui
2022-02-19 0:27 ` Shuah Khan [this message]
2022-02-20 15:20 ` [PATCH RESEND v6 0/9] cpupower: Add AMD P-State Support Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aafb93a-772c-1806-e087-cd285694aa74@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=Jinzhou.Su@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=alexander.deucher@amd.com \
--cc=bp@alien8.de \
--cc=deepak.sharma@amd.com \
--cc=ggherdovich@suse.cz \
--cc=li.meng@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@kernel.org \
--cc=nathan.fontenot@amd.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ray.huang@amd.com \
--cc=rostedt@goodmis.org \
--cc=steven@valvesoftware.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome