From: Huang Rui <ray.huang@amd.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Sharma, Deepak" <Deepak.Sharma@amd.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Limonciello, Mario" <Mario.Limonciello@amd.com>,
Steven Noonan <steven@valvesoftware.com>,
"Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
"Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
"Du, Xiaojian" <Xiaojian.Du@amd.com>,
"Yuan, Perry" <Perry.Yuan@amd.com>,
"Meng, Li (Jassmine)" <Li.Meng@amd.com>,
Borislav Petkov <bp@alien8.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Steven Rostedt <rostedt@goodmis.org>,
Giovanni Gherdovich <ggherdovich@suse.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND v6 0/9] cpupower: Add AMD P-State Support
Date: Sun, 20 Feb 2022 23:20:09 +0800 [thread overview]
Message-ID: <YhJcKXo5t6E/jy8x@amd.com> (raw)
In-Reply-To: <8aafb93a-772c-1806-e087-cd285694aa74@linuxfoundation.org>
Hi Shuah,
I am glad to see your comments again. Thanks for your time!
On Sat, Feb 19, 2022 at 08:27:41AM +0800, Shuah Khan wrote:
> On 2/16/22 12:35 AM, Huang Rui wrote:
> > Hi Shuah,
> >
> > Since AMD P-State kernel is merged into 5.17-rc1, I would like to continue
> > revising the AMD P-State support for the CPUPower tool. These series are
> > rebased on latest bleeding-edge, any comments are warm for me.
> >
> > See patch series of CPUPower in below git repo:
> > V1: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Frui%2Flinux.git%2Flog%2F%3Fh%3Damd-pstate-dev-v1&data=04%7C01%7Cray.huang%40amd.com%7C7f03b74e8f3044c8574008d9f33ea54e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637808272662923642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=L9G4msSTFHOztI8Dj5en2aC229%2Bn4xZl%2BGYMOG4R2dg%3D&reserved=0
> > V2: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Frui%2Flinux.git%2Flog%2F%3Fh%3Damd-pstate-dev-v2&data=04%7C01%7Cray.huang%40amd.com%7C7f03b74e8f3044c8574008d9f33ea54e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637808272662923642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ApWETuX6J%2BK5fbHV7ym0%2BYawxD3TAIqaffOCRlBz56g%3D&reserved=0
> > V3: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Frui%2Flinux.git%2Flog%2F%3Fh%3Damd-pstate-dev-v3&data=04%7C01%7Cray.huang%40amd.com%7C7f03b74e8f3044c8574008d9f33ea54e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637808272662923642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=wBn4bLwo4H8E8OIKbtIQ9Rw9AJ49ctk%2FpisN1P32Xpg%3D&reserved=0
> > V4: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Frui%2Flinux.git%2Flog%2F%3Fh%3Damd-pstate-dev-v4&data=04%7C01%7Cray.huang%40amd.com%7C7f03b74e8f3044c8574008d9f33ea54e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637808272662923642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=XITGUWrl4J01mx0V12Unn0ZuODqhAbLuS2eNUIM7IBE%3D&reserved=0
> > V5: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Frui%2Flinux.git%2Flog%2F%3Fh%3Damd-pstate-dev-v5&data=04%7C01%7Cray.huang%40amd.com%7C7f03b74e8f3044c8574008d9f33ea54e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637808272662923642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=D%2F2vCZrlrg3apxht1XX4GfRo1Unfc%2FMqyDX%2FRz0c%2FYU%3D&reserved=0
> > V6: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Frui%2Flinux.git%2Flog%2F%3Fh%3Dcpupower-amd-pstate&data=04%7C01%7Cray.huang%40amd.com%7C7f03b74e8f3044c8574008d9f33ea54e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637808272662923642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=g%2FDKBuQirt3pB9dIXkTFbqjyz8LdWBFbhIZBYcRqD8o%3D&reserved=0
> >
>
> A few checkpatch warns to fix. I usually ignore CHECK from checkpatch,
> but a few of them found on this series could improve the code.
>
I will use checkpatch script to scan all patches in these series.
> Also is there a need to add/update manpages and documentation.
>
Let me find a place to add some descriptions.
> I tested these my AMD Ryzen 7 4700G system. I didn't play with set commands
> and just the info ones.
>
> cpupower info gave me this output. The first message is fine, but the
> second one is a bit odd. Should it just bail out right after the first
> message about "not support"
>
> cpupower info
>
> System does not support Intel's performance bias setting
> analyzing CPU 0:
>
Let me take a look at this issue.
> Go ahead send me v7 for these and add any mapages/doc if necessary.
> I will get them into Linux 5.18-rc1
>
No problem, I will address the comments and send V7.
Thanks,
Ray
prev parent reply other threads:[~2022-02-20 15:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 7:35 Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 1/9] cpupower: Add AMD P-State capability flag Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 2/9] cpupower: Add the function to check AMD P-State enabled Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 3/9] cpupower: Initial AMD P-State capability Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 4/9] cpupower: Add the function to get the sysfs value from specific table Huang Rui
2022-02-18 23:46 ` Shuah Khan
2022-02-20 14:22 ` Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 5/9] cpupower: Introduce ACPI CPPC library Huang Rui
2022-02-18 23:53 ` Shuah Khan
2022-02-20 14:34 ` Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 6/9] cpupower: Add AMD P-State sysfs definition and access helper Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 7/9] cpupower: Enable boost state support for AMD P-State module Huang Rui
2022-02-19 0:01 ` Shuah Khan
2022-02-20 14:35 ` Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 8/9] cpupower: Move print_speed function into misc helper Huang Rui
2022-02-16 7:35 ` [PATCH RESEND v6 9/9] cpupower: Print AMD P-State information on cpupower Huang Rui
2022-02-19 0:27 ` [PATCH RESEND v6 0/9] cpupower: Add AMD P-State Support Shuah Khan
2022-02-20 15:20 ` Huang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhJcKXo5t6E/jy8x@amd.com \
--to=ray.huang@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Deepak.Sharma@amd.com \
--cc=Jinzhou.Su@amd.com \
--cc=Li.Meng@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=Nathan.Fontenot@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=bp@alien8.de \
--cc=ggherdovich@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=steven@valvesoftware.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome