mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: talos-evk: fix sdhc_2 vqmmc-supply for UHS-I mode
@ 2026-06-09  7:35 monish.chunara
  2026-06-09  8:31 ` Jie Gan
  2026-06-16 12:01 ` Konrad Dybcio
  0 siblings, 2 replies; 3+ messages in thread
From: monish.chunara @ 2026-06-09  7:35 UTC (permalink / raw)
  To: andersson, konradybcio, robh, krzk+dt, conor+dt
  Cc: linux-arm-msm, devicetree, linux-kernel, linux-mmc, ulf.hansson,
	nitin.rawat, pradeep.pragallapati, komal.bajaj, monish.chunara,
	jsodhapa

From: Monish Chunara <monish.chunara@oss.qualcomm.com>

SD card is detected as SDHS instead of UHS-I because sdhc_2 was
configured with vreg_s4a as vqmmc-supply, which cannot switch
between 1.8V and 3.3V.

Switch vqmmc-supply to vreg_l2a and update its voltage range to
1800000-2960000 uV to enable proper UHS-I signaling.

Signed-off-by: Jaypal Sodhaparmar <jsodhapa@qti.qualcomm.com>
Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 4 ++--
 arch/arm64/boot/dts/qcom/talos-evk.dts      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
index 294354c034c3..f70823b31391 100644
--- a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
+++ b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
@@ -195,8 +195,8 @@ vreg_l1a: ldo1 {
 
 		vreg_l2a: ldo2 {
 			regulator-name = "vreg_l2a";
-			regulator-min-microvolt = <1650000>;
-			regulator-max-microvolt = <3100000>;
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <2960000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
 			regulator-allow-set-load;
 			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
diff --git a/arch/arm64/boot/dts/qcom/talos-evk.dts b/arch/arm64/boot/dts/qcom/talos-evk.dts
index b7f514fbc7b2..9ed48765ae6e 100644
--- a/arch/arm64/boot/dts/qcom/talos-evk.dts
+++ b/arch/arm64/boot/dts/qcom/talos-evk.dts
@@ -189,7 +189,7 @@ &sdhc_2 {
 	cd-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>;
 
 	vmmc-supply = <&vreg_l10a>;
-	vqmmc-supply = <&vreg_s4a>;
+	vqmmc-supply = <&vreg_l2a>;
 
 	status = "okay";
 };
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: talos-evk: fix sdhc_2 vqmmc-supply for UHS-I mode
  2026-06-09  7:35 [PATCH] arm64: dts: qcom: talos-evk: fix sdhc_2 vqmmc-supply for UHS-I mode monish.chunara
@ 2026-06-09  8:31 ` Jie Gan
  2026-06-16 12:01 ` Konrad Dybcio
  1 sibling, 0 replies; 3+ messages in thread
From: Jie Gan @ 2026-06-09  8:31 UTC (permalink / raw)
  To: monish.chunara, andersson, konradybcio, robh, krzk+dt, conor+dt
  Cc: linux-arm-msm, devicetree, linux-kernel, linux-mmc, ulf.hansson,
	nitin.rawat, pradeep.pragallapati, komal.bajaj, jsodhapa



On 6/9/2026 3:35 PM, monish.chunara@oss.qualcomm.com wrote:
> From: Monish Chunara <monish.chunara@oss.qualcomm.com>
> 
> SD card is detected as SDHS instead of UHS-I because sdhc_2 was
> configured with vreg_s4a as vqmmc-supply, which cannot switch
> between 1.8V and 3.3V.
> 
> Switch vqmmc-supply to vreg_l2a and update its voltage range to
> 1800000-2960000 uV to enable proper UHS-I signaling.
> 

Please add Fixes tag for a fix patch.

> Signed-off-by: Jaypal Sodhaparmar <jsodhapa@qti.qualcomm.com>

why is there a signed-off-by tag? Does it belong to the original 
author's tag? If yes, why you are the author of the posted patch.

Thanks,
Jie

> Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
> ---
>   arch/arm64/boot/dts/qcom/talos-evk-som.dtsi | 4 ++--
>   arch/arm64/boot/dts/qcom/talos-evk.dts      | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> index 294354c034c3..f70823b31391 100644
> --- a/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/talos-evk-som.dtsi
> @@ -195,8 +195,8 @@ vreg_l1a: ldo1 {
>   
>   		vreg_l2a: ldo2 {
>   			regulator-name = "vreg_l2a";
> -			regulator-min-microvolt = <1650000>;
> -			regulator-max-microvolt = <3100000>;
> +			regulator-min-microvolt = <1800000>;
> +			regulator-max-microvolt = <2960000>;
>   			regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
>   			regulator-allow-set-load;
>   			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
> diff --git a/arch/arm64/boot/dts/qcom/talos-evk.dts b/arch/arm64/boot/dts/qcom/talos-evk.dts
> index b7f514fbc7b2..9ed48765ae6e 100644
> --- a/arch/arm64/boot/dts/qcom/talos-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/talos-evk.dts
> @@ -189,7 +189,7 @@ &sdhc_2 {
>   	cd-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>;
>   
>   	vmmc-supply = <&vreg_l10a>;
> -	vqmmc-supply = <&vreg_s4a>;
> +	vqmmc-supply = <&vreg_l2a>;
>   
>   	status = "okay";
>   };


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: talos-evk: fix sdhc_2 vqmmc-supply for UHS-I mode
  2026-06-09  7:35 [PATCH] arm64: dts: qcom: talos-evk: fix sdhc_2 vqmmc-supply for UHS-I mode monish.chunara
  2026-06-09  8:31 ` Jie Gan
@ 2026-06-16 12:01 ` Konrad Dybcio
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-06-16 12:01 UTC (permalink / raw)
  To: monish.chunara, andersson, konradybcio, robh, krzk+dt, conor+dt
  Cc: linux-arm-msm, devicetree, linux-kernel, linux-mmc, ulf.hansson,
	nitin.rawat, pradeep.pragallapati, komal.bajaj, jsodhapa

On 6/9/26 9:35 AM, monish.chunara@oss.qualcomm.com wrote:
> From: Monish Chunara <monish.chunara@oss.qualcomm.com>
> 
> SD card is detected as SDHS instead of UHS-I because sdhc_2 was
> configured with vreg_s4a as vqmmc-supply, which cannot switch
> between 1.8V and 3.3V.
> 
> Switch vqmmc-supply to vreg_l2a and update its voltage range to
> 1800000-2960000 uV to enable proper UHS-I signaling.
> 
> Signed-off-by: Jaypal Sodhaparmar <jsodhapa@qti.qualcomm.com>

Incorrect s-o-b chain - is Jaypal the original author, perhaps?

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-16 12:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-09  7:35 [PATCH] arm64: dts: qcom: talos-evk: fix sdhc_2 vqmmc-supply for UHS-I mode monish.chunara
2026-06-09  8:31 ` Jie Gan
2026-06-16 12:01 ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®