From: Andrew Lunn <andrew@lunn.ch>
To: Jacky Chou <jacky_chou@aspeedtech.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Po-Yu Chuang <ratbert@faraday-tech.com>,
Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"taoren@meta.com" <taoren@meta.com>
Subject: Re: [PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600
Date: Fri, 7 Nov 2025 03:01:25 +0100 [thread overview]
Message-ID: <8b2f985f-d24e-427e-88cc-94d9bc5815b2@lunn.ch> (raw)
In-Reply-To: <SEYPR06MB5134F0CF51189317B94377C09DC3A@SEYPR06MB5134.apcprd06.prod.outlook.com>
On Fri, Nov 07, 2025 at 01:12:08AM +0000, Jacky Chou wrote:
> Hi Andrew
>
> > > There are four MACs in the AST2600. In the DT bindings and DTS files,
> > > what would be the recommended way to identify which MAC is which?
> > > In version 3 of my patches, I used the aliases in the DTSI file to
> > > allow the driver to get the MAC index.
> >
> > It is a bit ugly, but you are working around broken behaviour, so sometimes you
> > need to accept ugly. The addresses are fixed. You know
> > 1e660000 is mac0, 1e680000 is mac1, etc. Put the addresses into the driver,
> > for compatible aspeed,ast2600-mac.
> >
>
> I used this fixed address as MAC index in the first version of this series.
> But the other reviewer mentioned maybe there has the other better way to
> identify index.
> https://lore.kernel.org/all/20250317095229.6f8754dd@fedora.home/
> I find the "aliase", on preparing the v2 and v3, I think it may be a way to
> do that. But I am not sure.
> So, I would like to confirm the other good way before submitting the next
> version.
The problem with alias is that it normally a board property, in the
.dts file. A board might want a different mapping, which could then
break delays.
Andrew
next prev parent reply other threads:[~2025-11-07 2:01 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 7:39 [PATCH net-next v3 0/4] Add AST2600 RGMII delay into ftgmac100 Jacky Chou
2025-11-03 7:39 ` [PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600 Jacky Chou
2025-11-04 2:38 ` Andrew Lunn
2025-11-04 5:14 ` Jacky Chou
2025-11-04 13:40 ` Andrew Lunn
2025-11-06 5:25 ` Jacky Chou
2025-11-04 4:07 ` Andrew Lunn
2025-11-04 5:22 ` 回覆: " Jacky Chou
2025-11-04 13:50 ` Andrew Lunn
2025-11-04 8:19 ` Krzysztof Kozlowski
2025-11-04 9:54 ` Jacky Chou
2025-11-04 10:07 ` Krzysztof Kozlowski
2025-11-06 5:41 ` Jacky Chou
2025-11-06 8:25 ` Krzysztof Kozlowski
2025-11-07 0:15 ` Jacky Chou
2025-11-07 0:46 ` Andrew Lunn
2025-11-07 1:12 ` Jacky Chou
2025-11-07 2:01 ` Andrew Lunn [this message]
2025-11-07 3:28 ` Jacky Chou
2025-11-03 7:39 ` [PATCH net-next v3 2/4] ARM: dts: aspeed-g6: Add ethernet alise Jacky Chou
2025-11-03 7:39 ` [PATCH net-next v3 3/4] ARM: dts: aspeed: ast2600-evb: Configure RGMII delay for MAC Jacky Chou
2025-11-04 3:49 ` Andrew Lunn
2025-11-04 4:00 ` Andrew Lunn
2025-11-04 4:54 ` 回覆: " Jacky Chou
2025-11-03 7:39 ` [PATCH net-next v3 4/4] net: ftgmac100: Add RGMII delay support for AST2600 Jacky Chou
2025-11-04 3:07 ` kernel test robot
2025-11-04 3:55 ` Andrew Lunn
2025-11-04 4:47 ` Jacky Chou
2025-11-04 8:20 ` [PATCH net-next v3 0/4] Add AST2600 RGMII delay into ftgmac100 Krzysztof Kozlowski
2025-11-04 8:35 ` 回覆: " Jacky Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b2f985f-d24e-427e-88cc-94d9bc5815b2@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jacky_chou@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ratbert@faraday-tech.com \
--cc=robh@kernel.org \
--cc=taoren@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®