* [PATCH] drivers/media/v4l2-core/v4l2-h264 : add detection of null pointers
@ 2022-12-27 2:36 Dong Chuanjian
2023-01-09 21:27 ` Nicolas Dufresne
0 siblings, 1 reply; 2+ messages in thread
From: Dong Chuanjian @ 2022-12-27 2:36 UTC (permalink / raw)
To: mchehab, hverkuil-cisco, nicolas.dufresne, sebastian.fricke, ezequiel
Cc: linux-media, linux-kernel, Dong Chuanjian
When the pointer variable is judged to be null, null is returned
directly.
Signed-off-by: Dong Chuanjian <chuanjian@nfschina.com>
---
v2: Directly return when pointer allocation fails.
v3: problems in synchronous repair format_ref_list_p
diff --git a/drivers/media/v4l2-core/v4l2-h264.c b/drivers/media/v4l2-core/v4l2-h264.c
index 72bd64f65198..f6684c1d7319 100644
--- a/drivers/media/v4l2-core/v4l2-h264.c
+++ b/drivers/media/v4l2-core/v4l2-h264.c
@@ -305,6 +305,8 @@ static const char *format_ref_list_p(const struct v4l2_h264_reflist_builder *bui
int n = 0, i;
*out_str = kmalloc(tmp_str_size, GFP_KERNEL);
+ if (*out_str == NULL)
+ return NULL;
n += snprintf(*out_str + n, tmp_str_size - n, "|");
@@ -343,6 +345,8 @@ static const char *format_ref_list_b(const struct v4l2_h264_reflist_builder *bui
int n = 0, i;
*out_str = kmalloc(tmp_str_size, GFP_KERNEL);
+ if (*out_str == NULL)
+ return NULL;
n += snprintf(*out_str + n, tmp_str_size - n, "|");
--
2.18.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/media/v4l2-core/v4l2-h264 : add detection of null pointers
2022-12-27 2:36 [PATCH] drivers/media/v4l2-core/v4l2-h264 : add detection of null pointers Dong Chuanjian
@ 2023-01-09 21:27 ` Nicolas Dufresne
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Dufresne @ 2023-01-09 21:27 UTC (permalink / raw)
To: Dong Chuanjian, mchehab, hverkuil-cisco, sebastian.fricke, ezequiel
Cc: linux-media, linux-kernel
Le mardi 27 décembre 2022 à 10:36 +0800, Dong Chuanjian a écrit :
> When the pointer variable is judged to be null, null is returned
> directly.
>
> Signed-off-by: Dong Chuanjian <chuanjian@nfschina.com>
Acked-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Please add the missing Fixes tag.
Fixes: d3f756ad629b39 ("media: v4l2: Trace calculated p/b0/b1 initial reflist")
If someone have time, the pr_debug should be ported to v4l2_debug according to
some other reviews.
> ---
> v2: Directly return when pointer allocation fails.
> v3: problems in synchronous repair format_ref_list_p
>
> diff --git a/drivers/media/v4l2-core/v4l2-h264.c b/drivers/media/v4l2-core/v4l2-h264.c
> index 72bd64f65198..f6684c1d7319 100644
> --- a/drivers/media/v4l2-core/v4l2-h264.c
> +++ b/drivers/media/v4l2-core/v4l2-h264.c
> @@ -305,6 +305,8 @@ static const char *format_ref_list_p(const struct v4l2_h264_reflist_builder *bui
> int n = 0, i;
>
> *out_str = kmalloc(tmp_str_size, GFP_KERNEL);
> + if (*out_str == NULL)
> + return NULL;
>
> n += snprintf(*out_str + n, tmp_str_size - n, "|");
>
> @@ -343,6 +345,8 @@ static const char *format_ref_list_b(const struct v4l2_h264_reflist_builder *bui
> int n = 0, i;
>
> *out_str = kmalloc(tmp_str_size, GFP_KERNEL);
> + if (*out_str == NULL)
> + return NULL;
>
> n += snprintf(*out_str + n, tmp_str_size - n, "|");
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-09 21:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-27 2:36 [PATCH] drivers/media/v4l2-core/v4l2-h264 : add detection of null pointers Dong Chuanjian
2023-01-09 21:27 ` Nicolas Dufresne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®