* [PATCH] mmc: davinci: Make SDIO irq truly optional
@ 2023-07-13 9:31 Julien Delbergue
2023-07-13 14:37 ` Bartosz Golaszewski
2023-07-14 9:49 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Julien Delbergue @ 2023-07-13 9:31 UTC (permalink / raw)
To: ulf.hansson; +Cc: linux-mmc, linux-kernel, brgl
The following error is printed on Logic PD's DA850 EVM:
davinci_mmc 1c40000.mmc: error -ENXIO: IRQ index 1 not found
Depending on the board, the SDIO interrupt may not be present, so use
the correct function to reflect that and prevent logging an error.
Signed-off-by: Julien Delbergue <j.delbergue.foss@gmail.com>
---
drivers/mmc/host/davinci_mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
index 7138dfa065bf..fb686c0d171c 100644
--- a/drivers/mmc/host/davinci_mmc.c
+++ b/drivers/mmc/host/davinci_mmc.c
@@ -1257,7 +1257,7 @@ static int davinci_mmcsd_probe(struct platform_device *pdev)
host->use_dma = use_dma;
host->mmc_irq = irq;
- host->sdio_irq = platform_get_irq(pdev, 1);
+ host->sdio_irq = platform_get_irq_optional(pdev, 1);
if (host->use_dma) {
ret = davinci_acquire_dma_channels(host);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: davinci: Make SDIO irq truly optional
2023-07-13 9:31 [PATCH] mmc: davinci: Make SDIO irq truly optional Julien Delbergue
@ 2023-07-13 14:37 ` Bartosz Golaszewski
2023-07-14 9:49 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2023-07-13 14:37 UTC (permalink / raw)
To: Julien Delbergue; +Cc: ulf.hansson, linux-mmc, linux-kernel
On Thu, Jul 13, 2023 at 11:31 AM Julien Delbergue
<j.delbergue.foss@gmail.com> wrote:
>
> The following error is printed on Logic PD's DA850 EVM:
> davinci_mmc 1c40000.mmc: error -ENXIO: IRQ index 1 not found
>
> Depending on the board, the SDIO interrupt may not be present, so use
> the correct function to reflect that and prevent logging an error.
>
> Signed-off-by: Julien Delbergue <j.delbergue.foss@gmail.com>
> ---
> drivers/mmc/host/davinci_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
> index 7138dfa065bf..fb686c0d171c 100644
> --- a/drivers/mmc/host/davinci_mmc.c
> +++ b/drivers/mmc/host/davinci_mmc.c
> @@ -1257,7 +1257,7 @@ static int davinci_mmcsd_probe(struct platform_device *pdev)
>
> host->use_dma = use_dma;
> host->mmc_irq = irq;
> - host->sdio_irq = platform_get_irq(pdev, 1);
> + host->sdio_irq = platform_get_irq_optional(pdev, 1);
>
> if (host->use_dma) {
> ret = davinci_acquire_dma_channels(host);
> --
> 2.34.1
Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: davinci: Make SDIO irq truly optional
2023-07-13 9:31 [PATCH] mmc: davinci: Make SDIO irq truly optional Julien Delbergue
2023-07-13 14:37 ` Bartosz Golaszewski
@ 2023-07-14 9:49 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2023-07-14 9:49 UTC (permalink / raw)
To: Julien Delbergue; +Cc: linux-mmc, linux-kernel, brgl
On Thu, 13 Jul 2023 at 11:31, Julien Delbergue
<j.delbergue.foss@gmail.com> wrote:
>
> The following error is printed on Logic PD's DA850 EVM:
> davinci_mmc 1c40000.mmc: error -ENXIO: IRQ index 1 not found
>
> Depending on the board, the SDIO interrupt may not be present, so use
> the correct function to reflect that and prevent logging an error.
>
> Signed-off-by: Julien Delbergue <j.delbergue.foss@gmail.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/davinci_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
> index 7138dfa065bf..fb686c0d171c 100644
> --- a/drivers/mmc/host/davinci_mmc.c
> +++ b/drivers/mmc/host/davinci_mmc.c
> @@ -1257,7 +1257,7 @@ static int davinci_mmcsd_probe(struct platform_device *pdev)
>
> host->use_dma = use_dma;
> host->mmc_irq = irq;
> - host->sdio_irq = platform_get_irq(pdev, 1);
> + host->sdio_irq = platform_get_irq_optional(pdev, 1);
>
> if (host->use_dma) {
> ret = davinci_acquire_dma_channels(host);
> --
> 2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-14 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-13 9:31 [PATCH] mmc: davinci: Make SDIO irq truly optional Julien Delbergue
2023-07-13 14:37 ` Bartosz Golaszewski
2023-07-14 9:49 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®