From: "Adrian McMenamin" <lkmladrian@gmail.com>
To: "Antonino A. Daplas" <adaplas@gmail.com>
Cc: lethal@linux-sh.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Framebuffer: Fix 16bpp colour output in Dreamcast pvr2fb
Date: Sat, 28 Jul 2007 15:51:38 +0100 [thread overview]
Message-ID: <8b67d60707280751k76539f06t9a0feb67f2acdcb0@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 268 bytes --]
Tony,
This patch - on top of your others - fixes the colour output for 16bpp
RGB565 output in the Dreamcast - it was a simple out by one error in
the bit shift.
Still looking at the 24bpp and 32bpp issues.
Signed-off by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: DC-16bpp.diff --]
[-- Type: text/x-patch; name="DC-16bpp.diff", Size: 450 bytes --]
diff --git a/drivers/video/pvr2fb.c b/drivers/video/pvr2fb.c
index 3ac32f3..383e87e 100644
--- a/drivers/video/pvr2fb.c
+++ b/drivers/video/pvr2fb.c
@@ -330,27 +331,28 @@ static int pvr2fb_setcolreg(unsigned int regno, unsigned int red,
case 16: /* RGB 565 */
tmp = (red & 0xf800) |
((green & 0xfc00) >> 5) |
- ((blue & 0xf800) >> 11);
+ ((blue & 0xf800) >> 10);
pvr2fb_set_pal_entry(par, regno, tmp);
next reply other threads:[~2007-07-28 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-28 14:51 Adrian McMenamin [this message]
[not found] ` <20070728171226.GA7247@localhost.localdomain>
2007-07-28 17:59 ` Adrian McMenamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b67d60707280751k76539f06t9a0feb67f2acdcb0@mail.gmail.com \
--to=lkmladrian@gmail.com \
--cc=adaplas@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®