[PATCH] Framebuffer: Fix 16bpp colour output in Dreamcast pvr2fb

[PATCH] Framebuffer: Fix 16bpp colour output in Dreamcast pvr2fb

[Adrian McMenamin]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

Tony,

This patch - on top of your others - fixes the colour output for 16bpp
RGB565 output in the Dreamcast - it was a simple out by one error in
the bit shift.

Still looking at the 24bpp and 32bpp issues.

Signed-off by: Adrian McMenamin <adrian@mcmen.demon.co.uk>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: DC-16bpp.diff --]
[-- Type: text/x-patch; name="DC-16bpp.diff", Size: 450 bytes --]

diff --git a/drivers/video/pvr2fb.c b/drivers/video/pvr2fb.c
index 3ac32f3..383e87e 100644
--- a/drivers/video/pvr2fb.c
+++ b/drivers/video/pvr2fb.c
@@ -330,27 +331,28 @@ static int pvr2fb_setcolreg(unsigned int regno, unsigned int red,
 	    case 16: /* RGB 565 */
 		tmp =  (red   & 0xf800)       |
 		      ((green & 0xfc00) >> 5) |
-		      ((blue  & 0xf800) >> 11);
+		      ((blue  & 0xf800) >> 10);
 
 		pvr2fb_set_pal_entry(par, regno, tmp);

Re: [PATCH] Framebuffer: Fix 16bpp colour output in Dreamcast pvr2fb

[Adrian McMenamin]

On 28/07/07, Ondrej Zajicek <santiago@crfreenet.org> wrote:
> On Sat, Jul 28, 2007 at 03:51:38PM +0100, Adrian McMenamin wrote:
> > Tony,
> >
> > This patch - on top of your others - fixes the colour output for 16bpp
> > RGB565 output in the Dreamcast - it was a simple out by one error in
> > the bit shift.
>
> > @@ -330,27 +331,28 @@ static int pvr2fb_setcolreg(unsigned int regno, unsigned int red,
> >           case 16: /* RGB 565 */
> >               tmp =  (red   & 0xf800)       |
> >                     ((green & 0xfc00) >> 5) |
> > -                   ((blue  & 0xf800) >> 11);
> > +                   ((blue  & 0xf800) >> 10);
>
> This mixes lsb of green with msb of blue. If you want RGB 565,
> then >> 11 is correct. If you want RGB 555, green should
> be anded with 0xf800.
>
You are, of course, quite right, which makes it all the more the
strange that it appeared to fix the problem. Back to the drawing board
then.