* [PATCH] HID: amd_sfh: Convert comma to semicolon
@ 2024-09-03 2:44 Chen Ni
2024-09-03 9:41 ` Basavaraj Natikar
2024-09-03 11:39 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Chen Ni @ 2024-09-03 2:44 UTC (permalink / raw)
To: basavaraj.natikar, jikos, bentiss, Shyam-sundar.S-k, mario.limonciello
Cc: linux-input, linux-kernel, Chen Ni
Replace a comma between expression statements by a semicolon.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
index 621793d92464..db36d87d5634 100644
--- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
+++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
@@ -299,8 +299,8 @@ static void amd_sfh_set_ops(struct amd_mp2_dev *mp2)
sfh_interface_init(mp2);
mp2_ops = mp2->mp2_ops;
- mp2_ops->clear_intr = amd_sfh_clear_intr_v2,
- mp2_ops->init_intr = amd_sfh_irq_init_v2,
+ mp2_ops->clear_intr = amd_sfh_clear_intr_v2;
+ mp2_ops->init_intr = amd_sfh_irq_init_v2;
mp2_ops->suspend = amd_sfh_suspend;
mp2_ops->resume = amd_sfh_resume;
mp2_ops->remove = amd_mp2_pci_remove;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: amd_sfh: Convert comma to semicolon
2024-09-03 2:44 [PATCH] HID: amd_sfh: Convert comma to semicolon Chen Ni
@ 2024-09-03 9:41 ` Basavaraj Natikar
2024-09-03 11:39 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Basavaraj Natikar @ 2024-09-03 9:41 UTC (permalink / raw)
To: Chen Ni, basavaraj.natikar, jikos, bentiss, Shyam-sundar.S-k,
mario.limonciello
Cc: linux-input, linux-kernel
On 9/3/2024 8:14 AM, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> index 621793d92464..db36d87d5634 100644
> --- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> +++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> @@ -299,8 +299,8 @@ static void amd_sfh_set_ops(struct amd_mp2_dev *mp2)
>
> sfh_interface_init(mp2);
> mp2_ops = mp2->mp2_ops;
> - mp2_ops->clear_intr = amd_sfh_clear_intr_v2,
> - mp2_ops->init_intr = amd_sfh_irq_init_v2,
> + mp2_ops->clear_intr = amd_sfh_clear_intr_v2;
> + mp2_ops->init_intr = amd_sfh_irq_init_v2;
> mp2_ops->suspend = amd_sfh_suspend;
> mp2_ops->resume = amd_sfh_resume;
> mp2_ops->remove = amd_mp2_pci_remove;
Looks good to me.
Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Thanks,
--
Basavaraj
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: amd_sfh: Convert comma to semicolon
2024-09-03 2:44 [PATCH] HID: amd_sfh: Convert comma to semicolon Chen Ni
2024-09-03 9:41 ` Basavaraj Natikar
@ 2024-09-03 11:39 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2024-09-03 11:39 UTC (permalink / raw)
To: Chen Ni
Cc: basavaraj.natikar, bentiss, Shyam-sundar.S-k, mario.limonciello,
linux-input, linux-kernel
On Tue, 3 Sep 2024, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> index 621793d92464..db36d87d5634 100644
> --- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> +++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> @@ -299,8 +299,8 @@ static void amd_sfh_set_ops(struct amd_mp2_dev *mp2)
>
> sfh_interface_init(mp2);
> mp2_ops = mp2->mp2_ops;
> - mp2_ops->clear_intr = amd_sfh_clear_intr_v2,
> - mp2_ops->init_intr = amd_sfh_irq_init_v2,
> + mp2_ops->clear_intr = amd_sfh_clear_intr_v2;
> + mp2_ops->init_intr = amd_sfh_irq_init_v2;
> mp2_ops->suspend = amd_sfh_suspend;
> mp2_ops->resume = amd_sfh_resume;
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-03 11:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-03 2:44 [PATCH] HID: amd_sfh: Convert comma to semicolon Chen Ni
2024-09-03 9:41 ` Basavaraj Natikar
2024-09-03 11:39 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®