From: Johannes Berg <johannes@sipsolutions.net>
To: Shuah Khan <skhan@linuxfoundation.org>,
Jiunn Chang <c0d1n61at3@gmail.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Linux-kernel-mentees][PATCH v2] nl80211: Fix undefined behavior in bit shift
Date: Fri, 28 Jun 2019 15:57:05 +0200 [thread overview]
Message-ID: <8b8c44c3ecb8626d9bb5a8f786b1d2b7488df86b.camel@sipsolutions.net> (raw)
In-Reply-To: <c20a0a94-ab50-bb85-7c78-e02a465c5a40@linuxfoundation.org> (sfid-20190627_053427_689527_6C7A1CBE)
On Wed, 2019-06-26 at 21:34 -0600, Shuah Khan wrote:
> On 6/26/19 9:25 PM, Jiunn Chang wrote:
> > Shifting signed 32-bit value by 31 bits is undefined. Changing most
> > significant bit to unsigned.
> >
> > Changes included in v2:
> > - use subsystem specific subject lines
> > - CC required mailing lists
> >
> > Signed-off-by: Jiunn Chang <c0d1n61at3@gmail.com>
> > ---
>
> Move version change lines here. They don't belong in the commit log.
FWIW, in many cases people (maintainers) now *do* want them in the
commit log. Here, they're just editorial, so agree, but if real
technical changes were made due to reviews, they can indeed be useful.
johannes
next prev parent reply other threads:[~2019-06-28 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190627010137.5612-4-c0d1n61at3@gmail.com>
2019-06-27 3:25 ` Jiunn Chang
2019-06-27 3:34 ` Shuah Khan
2019-06-28 13:57 ` Johannes Berg [this message]
2019-06-28 15:04 ` Shuah Khan
2019-06-28 15:17 ` Johannes Berg
2019-06-28 15:27 ` Shuah Khan
2019-07-04 18:34 ` Jiunn Chang
2019-07-04 20:20 ` Johannes Berg
2019-06-27 5:04 ` [Linux-kernel-mentees][PATCH v3] " Jiunn Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b8c44c3ecb8626d9bb5a8f786b1d2b7488df86b.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=c0d1n61at3@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®