Re: [RFC] ASoC: codecs: msm8916-wcd-analog: use btn0 released detection

[Srinivas Kandagatla <srinivas.kandagatla@linaro.org>]

On 19/09/17 06:22, Damien Riegel wrote:
> Definitely. I also noticed an issue with the first very detection
> because the micbias will only be set the first time the driver gets a
> mechanical insertion interrupt. Following snippet seems to solve the
> problem:
Does that mean that you do not need the "ASoC: codecs: 
msm8916-wcd-analog: use btn0 released detection" patch anymore?

Below changes seems to fine as it is.

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


> diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
> index f562f2d86907..5045dabd9ea9 100644
> --- a/sound/soc/codecs/msm8916-wcd-analog.c
> +++ b/sound/soc/codecs/msm8916-wcd-analog.c
> @@ -446,6 +446,7 @@ static int pm8916_wcd_analog_enable_micbias_int1(struct
>   static void pm8916_wcd_setup_mbhc(struct pm8916_wcd_analog_priv *wcd)
>   {
>          struct snd_soc_codec *codec = wcd->codec;
> +       bool micbias_enabled = false;
>          u32 plug_type = 0;
>          u32 int_en_mask;
> 
> @@ -477,6 +478,11 @@ static void pm8916_wcd_setup_mbhc(struct pm8916_wcd_analog_priv *wcd)
>                              DIG_CLK_CTL_D_MBHC_CLK_EN_MASK,
>                              DIG_CLK_CTL_D_MBHC_CLK_EN);
> 
> +       if (snd_soc_read(codec, CDC_A_MICB_2_EN) & CDC_A_MICB_2_EN_ENABLE)
> +               micbias_enabled = true;
> +
> +       pm8916_mbhc_configure_bias(priv, micbias_enabled);
> +
>          int_en_mask = MBHC_SWITCH_INT;
>          if (wcd->mbhc_btn_enabled)
>                  int_en_mask |= MBHC_BUTTON_PRESS_DET | MBHC_BUTTON_RELEASE_DET;
>