From: "Mike Frysinger" <vapier.adi@gmail.com>
To: rmk@arm.linux.org.uk
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org,
"Robin Getz" <rgetz@blackfin.uclinux.org>
Subject: should RTS init in serial core be tied to CRTSCTS
Date: Thu, 1 Mar 2007 19:03:02 -0500 [thread overview]
Message-ID: <8bd0f97a0703011603m794e00f5x875eb68ad0db05de@mail.gmail.com> (raw)
the console= bootcmd allows for controlling of the initial state of
flow control by adding/omitting the 'r' suffix ... however, the
uart_startup() function in serial_core.c always calls down into the
serial driver with TIOCM_RTS:
static int uart_startup(...) {
...
/*
* Setup the RTS and DTR signals once the
* port is open and ready to respond.
*/
if (info->tty->termios->c_cflag & CBAUD)
uart_set_mctrl(port, TIOCM_RTS | TIOCM_DTR);
...
shouldnt TIOCM_RTS be passed down only when the 'r' is appended to the
boot cmdline ? perhaps like this:
uart_set_mctrl(port, (info->flags & UIF_CTS_FLOW ? TIOCM_RTS : 0) | TIOCM_DTR);
assuming too that TIOCM_DTR should always be set ...
-mike
next reply other threads:[~2007-03-02 0:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-02 0:03 Mike Frysinger [this message]
2007-03-04 16:20 ` Robin Getz
2007-03-04 19:46 ` Russell King
2007-03-04 20:42 ` Robin Getz
2007-03-05 8:39 ` Russell King
2007-03-05 17:09 ` Mike Frysinger
2007-03-05 17:56 ` Russell King
2007-03-05 18:13 ` Mike Frysinger
2007-03-06 20:40 ` Krzysztof Halasa
2007-03-06 23:24 ` Robin Getz
2007-03-07 12:46 ` Krzysztof Halasa
2007-03-07 13:38 ` Oleksiy Kebkal
2007-03-07 15:19 ` Robin Getz
2007-03-07 21:30 ` Oleksiy Kebkal
2007-03-08 13:44 ` Robin Getz
2007-03-08 13:48 ` Russell King
2007-03-08 14:16 ` Carl-Daniel Hailfinger
2007-03-08 14:20 ` Russell King
2007-03-08 16:51 ` Krzysztof Halasa
2007-03-08 18:43 ` Tosoni
2007-03-09 20:39 ` Krzysztof Halasa
2007-03-12 9:22 ` Tosoni
2007-03-12 12:59 ` Krzysztof Halasa
2007-03-08 14:23 ` Oleksiy Kebkal
2007-03-08 14:28 ` Russell King
2007-03-08 14:40 ` Oleksiy Kebkal
2007-03-08 14:25 ` Oleksiy Kebkal
2007-03-08 20:23 ` Robin Getz
2007-03-08 20:40 ` Russell King
2007-03-08 23:32 ` Robin Getz
2007-03-09 8:57 ` Russell King
2007-03-09 14:18 ` Oleksiy Kebkal
2007-03-07 12:54 ` Oleksiy Kebkal
2007-03-07 13:03 ` Krzysztof Halasa
2007-03-07 20:04 ` Mike Frysinger
2007-03-07 5:13 ` Oleksiy Kebkal
2007-03-07 12:48 ` Krzysztof Halasa
2007-03-05 8:23 Oleksiy Kebkal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bd0f97a0703011603m794e00f5x875eb68ad0db05de@mail.gmail.com \
--to=vapier.adi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rgetz@blackfin.uclinux.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome